From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43740C433DF for ; Thu, 23 Jul 2020 18:45:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C342720737 for ; Thu, 23 Jul 2020 18:45:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="cA/OihBN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gerhold.net header.i=@gerhold.net header.b="XQX02bTL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C342720737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5D1B11682; Thu, 23 Jul 2020 20:44:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5D1B11682 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595529939; bh=l13iX/k63EVgwWG5OsvwW6cFWfuWjY2UHoS6a7QzOuQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cA/OihBN+b0cZcViZF8nTUKK/8Ee0b8HXQs55ZyZxFQb8ikeT5Y+zz+3JB/eQ41RW qOb0umC9nPHaK5yGjws2/r/1/Xo7m1KiXF0xM8BwX2nR62yCKl8UL+Qw3nBL4nKgoS qnI9xTz7XlgOFjkxbzx3ztF4qPgIx9EshPLxu+fE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DC4A3F80212; Thu, 23 Jul 2020 20:44:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 25A98F80212; Thu, 23 Jul 2020 20:44:47 +0200 (CEST) Received: from mo4-p03-ob.smtp.rzone.de (mo4-p03-ob.smtp.rzone.de [85.215.255.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D806AF8011F for ; Thu, 23 Jul 2020 20:44:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D806AF8011F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gerhold.net header.i=@gerhold.net header.b="XQX02bTL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1595529883; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=ZBGeT5meaENGUkHBjaTnLB8Wyc3JbNoxdGt3rTZZJuE=; b=XQX02bTL9X0bVFPOAxK9t0oXsX61bOpvyP1grblyHsw08+cGqoCITQIgEo/p4a/GmD topcUO805HGkg+8x0oLl+Dqvm3FW+tl3wvejZfWYamaTWAXGTxwojGpjLpZVN56TphL9 +QnDUP0g3wDC2Pp7kCgFpK9+LeUiiFXuMvhliKTIK8SM9XNYwqQOaxpEXX4KIe5O8mCS vS35uugaxUiPw/nBXelftxE/qnA069u1x6DJiWlghI4pAzz3i5qp1daLKbtRQrCLZ5kL FrFX9lqHQ+13Nu/02dPpUKvUif3bnurHQcMqN4TgDPJ8S36uVppbqOyp1lfai+1ZPMHb CJ5Q== X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u26zEodhPgRDZ8j7IczHboo=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 46.10.5 DYNA|AUTH) with ESMTPSA id Y0939ew6NIif5J4 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 23 Jul 2020 20:44:41 +0200 (CEST) Date: Thu, 23 Jul 2020 20:44:36 +0200 From: Stephan Gerhold To: Srinivas Kandagatla Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration Message-ID: <20200723184432.GA321518@gerhold.net> References: <20200721104422.369368-1-cychiang@chromium.org> <20200721104422.369368-3-cychiang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: Taniya Das , devicetree@vger.kernel.org, tzungbi@chromium.org, Banajit Goswami , alsa-devel@alsa-project.org, Liam Girdwood , linux-arm-msm@vger.kernel.org, Patrick Lai , Takashi Iwai , linux-kernel@vger.kernel.org, Rob Herring , Bjorn Andersson , Mark Brown , Rohit kumar , Andy Gross , dianders@chromium.org, Ajit Pandey , dgreid@chromium.org, linux-arm-kernel@lists.infradead.org, Cheng-Yi Chiang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > +static int sc7180_parse_of(struct snd_soc_card *card) > > +{ > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > it will be nice to common this up, if possible! > FYI, I started work on making apq8016_sbc use qcom_snd_parse_of() a while ago already, but didn't find the time to finish it up. I have now sent it, this should make it possible to use the common qcom_snd_parse_of() function in this driver as well. See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/ Stephan