From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C28A8C433E1 for ; Fri, 24 Jul 2020 13:03:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41FEA2065E for ; Fri, 24 Jul 2020 13:03:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="lbEzaMbm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yih6vnsy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41FEA2065E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B9784167F; Fri, 24 Jul 2020 15:02:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B9784167F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595595791; bh=CT3kJd1MVqXnPYiZORFlfInUGpovklHtPZAv5w59S7Y=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lbEzaMbm47cUnZSjk5mK0CgqwYyd3fCyaFzsbsL1uAsdAldPLqvRK/R5IIfT/xY1f OXqaSZarPuQ8Q53yNuFVeJHXKq71avKR71nuwuS443E9TGns3n3HQmr/ELfZ1B+YMm kOtdqX+bSxz2JmjHH5OQzhEuRN69W+mOJXx4SgC4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3175CF80141; Fri, 24 Jul 2020 15:02:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 16BC6F8014C; Fri, 24 Jul 2020 15:02:19 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D53FFF800CE for ; Fri, 24 Jul 2020 15:02:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D53FFF800CE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yih6vnsy" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96AC42065E; Fri, 24 Jul 2020 13:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595595726; bh=CT3kJd1MVqXnPYiZORFlfInUGpovklHtPZAv5w59S7Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yih6vnsy6ym1vz2+Wl2FhQQjn/l3dvbGv8MQLrpb7db0Yf9xbWnVCsz2oi59avBEM CJdx+Eh73rF6cl91YwI35bJ9JM+HkmlHwYvzhhU0zqsCbuQS/FP+s3oiHgYyHVAP+B Twx/NH1bFvqL+QfQCK6ismwv/FhecE75L9Cc4bdM= Date: Fri, 24 Jul 2020 14:01:51 +0100 From: Mark Brown To: Tzung-Bi Shih Subject: Re: [PATCH] ASoC: dapm: don't call pm_runtime_* on card device Message-ID: <20200724130151.GG5664@sirena.org.uk> References: <20200724070731.451377-1-tzungbi@google.com> <20200724111634.GB5664@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jt0yj30bxbg11sci" Content-Disposition: inline In-Reply-To: X-Cookie: You will wish you hadn't. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: ALSA development , Liam Girdwood X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --jt0yj30bxbg11sci Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 24, 2020 at 08:26:13PM +0800, Tzung-Bi Shih wrote: > On Fri, Jul 24, 2020 at 7:16 PM Mark Brown wrote: > > Why is this a good fix, as opposed to only skipping the set_bias_level() > > bit? > Did you mean: skip to call snd_soc_dapm_set_bias_level() in > dapm_pre_sequence_async() and dapm_post_sequence_async()? No, I mean why not just add the missing puts which are currently being skipped due to being caught up with the bias level changes. --jt0yj30bxbg11sci Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8a274ACgkQJNaLcl1U h9AoHAf9H7byq5hdBVcD7CU372Q/Hg7BAxu4cHvndfJdS1aLLSAQSK/nbFT6Yt7N WrUFdxkBv/YdztQObTB7DStCdefjWe5y5KeAUbAL8ctB9Jv3DmJJMgJyNnp9wykG jAIKfSjsOOYFDizfiZpM++xTJBITpWAVIr96bZg6sdWROS5HEJHEZtu+qq+FKSmb GojNuZjj34ZusjQHHonaD5cGVq6lJGWRViuWx7S5i7t2PF6S4ucQK9TWBrGlN9HU L5+673M5UVobMDEE36hO0z+FCfnWx8KWFW6y/seYVqtZCOuv6TDoB2YzglC0LPAH gH/GlFukx3hqzxZ76NjkXBkGvZe/BA== =F/Bo -----END PGP SIGNATURE----- --jt0yj30bxbg11sci--