From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22FAC433E1 for ; Thu, 30 Jul 2020 13:50:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FBFA2074B for ; Thu, 30 Jul 2020 13:50:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="OtF5TyaM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FBFA2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BA3E61799; Thu, 30 Jul 2020 15:50:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BA3E61799 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596117050; bh=emDEt9Fq0R1ZUT4hwRKaKscOn0wke5BKzDhIXYI54bQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OtF5TyaM4Jbu3yovGBoWpjHBAG6hP6lqQSgR56lNTJcwI7PyjVES5Os1KX9tI/TXP Qv0Yzv20c+7fHf/x6KMEj41gfZkCeutgU1eqn383QBGMqE1Nhy8uU8wRDi0B6zCJJA FGrQeY5r3as3lNLMolGpuIderqqCjyaHJlA68dII= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 44CCCF8021C; Thu, 30 Jul 2020 15:50:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 79684F8021E; Thu, 30 Jul 2020 15:49:58 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CAE52F8012F for ; Thu, 30 Jul 2020 15:49:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CAE52F8012F IronPort-SDR: iOxmRrna/UajVCTENnZXhAIdHyyDjZrcKstfafesmZyUD2WbaZZ27RbJ82eR8if2kjUr6eMDXJ ckV7WCm88HHw== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="152821046" X-IronPort-AV: E=Sophos;i="5.75,414,1589266800"; d="scan'208";a="152821046" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 06:49:42 -0700 IronPort-SDR: YfxvqpoKyzsmflNuxxBu6oPO+XZR32091cdTsL9vvl0irDWf+tVtZQf7QpLfYe2mK03lFSlx+h Ha7SQi7AyuYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,414,1589266800"; d="scan'208";a="490662970" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006.fm.intel.com with ESMTP; 30 Jul 2020 06:49:38 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k18wD-004xUf-Rl; Thu, 30 Jul 2020 16:49:37 +0300 Date: Thu, 30 Jul 2020 16:49:37 +0300 From: Andy Shevchenko To: "Lu, Brent" Subject: Re: [PATCH v2 2/2] ASoC: Intel: Add period size constraint on strago board Message-ID: <20200730134937.GK3703480@smile.fi.intel.com> References: <1596096815-32043-1-git-send-email-brent.lu@intel.com> <1596096815-32043-3-git-send-email-brent.lu@intel.com> <20200730084219.GF3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: Guennadi Liakhovetski , "alsa-devel@alsa-project.org" , Kai Vehmanen , Kuninori Morimoto , "linux-kernel@vger.kernel.org" , Takashi Iwai , Jie Yang , "Rojewski, Cezary" , Pierre-Louis Bossart , Liam Girdwood , Sam McNally , Mark Brown , Ranjani Sridharan , Daniel Stuart , Yu-Hsuan Hsu , Damian van Soelen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Jul 30, 2020 at 01:23:57PM +0000, Lu, Brent wrote: > > On Thu, Jul 30, 2020 at 04:13:35PM +0800, Brent Lu wrote: > > > From: Yu-Hsuan Hsu > > > > > > The CRAS server does not set the period size in hw_param so ALSA will > > > calculate a value for period size which is based on the buffer size > > > and other parameters. The value may not always be aligned with Atom's > > > dsp design so a constraint is added to make sure the board always has > > > a good value. > > > > > > Cyan uses chtmax98090 and others(banon, celes, edgar, kefka...) use > > > rt5650. > > > > Actually one more comment here. > > Can you split per machine driver? > > > > It adds constraints on BSW Chromebooks for same purpose. I don't see the > benefit to split it. I didn't get this. Purpose of splitting this to two is to keep track on per driver basis what has had happen there. But it's minor and up to maintainers, of course. -- With Best Regards, Andy Shevchenko