From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD536C433DF for ; Fri, 31 Jul 2020 18:33:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FD0321744 for ; Fri, 31 Jul 2020 18:33:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="A4uRLBk2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FD0321744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D1F4A165E; Fri, 31 Jul 2020 20:33:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D1F4A165E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596220436; bh=V94zdN5H+e3SBeRoUvNUIb+YtxH496y/vXGq3vfRfWg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=A4uRLBk2OqSnxHz104SgSX4jwDzkE+3cFiTbRv7Czr3CUzXcCtk22VBZVIyAGrb/+ V3UlzfuqWnKCIh42hQKD+dEAi0oCDYdhs6XltpYc+absdvZKhcFQQPvcCDSyMH+/7g tgYGPnSGTw6huIug9njJEgBwoViBwQ8S8UprErwo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 38B64F80161; Fri, 31 Jul 2020 20:33:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3BCAEF80171; Fri, 31 Jul 2020 20:33:04 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 03E7AF8015C for ; Fri, 31 Jul 2020 20:32:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 03E7AF8015C Received: by mail-il1-f196.google.com with SMTP id s21so26117403ilk.5 for ; Fri, 31 Jul 2020 11:32:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EowHBI4dMeGjG0e5BJ+8WQXeSAJSfhXVUUltMQUkAHk=; b=TQZUqIAVU9SLTcpYzaQZRgNAJtpVjdgaEvkMfVSHsvvDdTvBjPTk4tzDRjdpZfxLMA eqk445UlKRb6P4WvulRFZiIKe7URF5Q2Nw7I63To9Qwy6UPhMyQUJ4s8IaO7nnCS1HYL zeI9oVtQJl3B0DKPIyI6p5IpRDlcG0ZP4OL+lU/3I4J0KXjc4k22r/6rASC45D64f4+H d4FLPRYHWIuC3GaEpCMcXtG1n3my6CtxqnA0cfyjaLffFTr9T3d1lFkMJ1PuWk4EFgmN 8twtFihktyzs2lYuhDJPVpZmv2R/15oQqjlqYiKJvo3YjDjP+hojVXngLeYuybQZDSoM pVcg== X-Gm-Message-State: AOAM531WgEhL3o2vvyGOmGKmpQBKaa2lYmdkMtduoGmvTCQOTGz/6fqf F699utR1UsIzfac1acnHMQ== X-Google-Smtp-Source: ABdhPJyRXrrrBCybFoJ4FQVs6g+pcQdN2eOBcJP56L5uwDXTsMph9xwyQUcqO122bYXED9rj7MLeUg== X-Received: by 2002:a92:9687:: with SMTP id g129mr4824817ilh.219.1596220371327; Fri, 31 Jul 2020 11:32:51 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id y8sm5097640ilq.21.2020.07.31.11.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 11:32:50 -0700 (PDT) Received: (nullmailer pid 540647 invoked by uid 1000); Fri, 31 Jul 2020 18:32:48 -0000 Date: Fri, 31 Jul 2020 12:32:48 -0600 From: Rob Herring To: Cheng-Yi Chiang Subject: Re: [PATCH v3 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings Message-ID: <20200731183248.GB531472@bogus> References: <20200731084023.2678931-1-cychiang@chromium.org> <20200731084023.2678931-2-cychiang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200731084023.2678931-2-cychiang@chromium.org> Cc: Taniya Das , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Banajit Goswami , Stephan Gerhold , Liam Girdwood , linux-arm-msm@vger.kernel.org, Patrick Lai , Takashi Iwai , linux-kernel@vger.kernel.org, tzungbi@chromium.org, Bjorn Andersson , Mark Brown , Rohit kumar , Andy Gross , dianders@chromium.org, Srini Kandagatla , dgreid@chromium.org, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jul 31, 2020 at 04:40:22PM +0800, Cheng-Yi Chiang wrote: > Add devicetree bindings documentation file for sc7180 sound card. > > Signed-off-by: Cheng-Yi Chiang > --- > .../bindings/sound/qcom,sc7180.yaml | 113 ++++++++++++++++++ > 1 file changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > new file mode 100644 > index 000000000000..ce8a5a2d9df9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,sc7180.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver > + > +maintainers: > + - Rohit kumar > + - Cheng-Yi Chiang > + > +description: > + This binding describes the SC7180 sound card which uses LPASS for audio. > + > +definitions: Please don't use 'definitions'. Either just duplicate it or you can do 'patternProperties'. > + > + dai: > + type: object > + properties: > + sound-dai: > + maxItems: 1 > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: phandle array of the codec or CPU DAI This is a common property. You can assume we have a common schema definition for it. IOW, 'sound-dai: true' is enough as it's always a single phandle+args. > + > + required: > + - sound-dai > + > +properties: > + compatible: > + contains: > + const: qcom,sc7180-sndcard > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + pair of strings, the first being the connection's sink, the second > + being the connection's source. > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + aux-dev: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle of the codec for headset detection > + > +patternProperties: > + "^dai-link(@[0-9]+)?$": > + description: > + Each subnode represents a dai link. Subnodes of each dai links would be > + cpu/codec dais. > + > + type: object > + > + properties: > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > + cpu: > + $ref: "#/definitions/dai" > + > + codec: > + $ref: "#/definitions/dai" > + > + required: > + - link-name > + - cpu > + - codec > + > + additionalProperties: false > + > +examples: > + > + - | > + sound { > + compatible = "qcom,sc7180-sndcard"; > + model = "sc7180-snd-card"; > + > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + > + aux-dev = <&alc5682>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dai-link@0 { > + link-name = "MultiMedia0"; > + cpu { > + sound-dai = <&lpass_cpu 0>; > + }; > + > + codec { > + sound-dai = <&alc5682 0>; > + }; > + }; > + > + dai-link@1 { > + link-name = "MultiMedia1"; > + cpu { > + sound-dai = <&lpass_cpu 1>; > + }; > + > + codec { > + sound-dai = <&max98357a>; > + }; > + }; > + }; > -- > 2.28.0.163.g6104cc2f0b6-goog >