alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 15/21] ASoC: Intel: haswell-ipc: remove redundant assignments
Date: Thu, 13 Aug 2020 15:01:41 -0500	[thread overview]
Message-ID: <20200813200147.61990-16-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200813200147.61990-1-pierre-louis.bossart@linux.intel.com>

Fix cppcheck warnings:

sound/soc/intel/haswell/sst-haswell-ipc.c:430:8: style: Variable 'i'
is assigned a value that is never used. [unreadVariable]

sound/soc/intel/haswell/sst-haswell-ipc.c:1792:8: style: Variable 'id'
is assigned a value that is never used. [unreadVariable]

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/haswell/sst-haswell-ipc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c
index 0ff89ea96ccf..345fd7c1b1d7 100644
--- a/sound/soc/intel/haswell/sst-haswell-ipc.c
+++ b/sound/soc/intel/haswell/sst-haswell-ipc.c
@@ -427,7 +427,7 @@ static void hsw_fw_ready(struct sst_hsw *hsw, u32 header)
 	u32 offset;
 	u8 fw_info[IPC_MAX_MAILBOX_BYTES - 5 * sizeof(u32)];
 	char *tmp[5], *pinfo;
-	int i = 0;
+	int i;
 
 	offset = (header & 0x1FFFFFFF) << 3;
 
@@ -1789,7 +1789,7 @@ int sst_hsw_store_param_line(struct sst_hsw *hsw, u8 *buf)
 
 int sst_hsw_load_param_line(struct sst_hsw *hsw, u8 *buf)
 {
-	u8 id = 0;
+	u8 id;
 
 	/* read the first matching line from param buffer */
 	while (hsw->param_idx_r < WAVES_PARAM_LINES) {
-- 
2.25.1


  parent reply	other threads:[~2020-08-13 20:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13 20:01 [PATCH 00/21] ASoC: Intel: fix cppcheck warnings Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 01/21] ASoC: Intel: Atom: sst-atom-controls: remove redundant assignments Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 02/21] ASoC: Intel: Atom: compress: remove redundant assignment Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 03/21] ASoC: Intel: Atom: platform-pcm: " Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 04/21] ASoC: Intel: Atom: sst: remove useless NULL assignment Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 05/21] ASoC: Intel: Atom: remove redundant initialization Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 06/21] ASoC: Intel: Atom: sst_pvt: " Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 07/21] ASoC: Intel: Atom: platform-pcm: fix redundant return Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 08/21] ASoC: Intel: Atom: remove useless assignment Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 09/21] ASoC: Intel: Atom: sst_loader: remove always-true condition Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 10/21] ASoC: Intel: Atom: sst_pvt: simplify return handling Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 11/21] ASoC: Intel: Atom: (cosmetic) align parameters Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 12/21] ASoC: Intel: Baytrail: (cosmetic) align function parameters Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 13/21] ASoC: Intel: common: " Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 14/21] ASoC: Intel: haswell: " Pierre-Louis Bossart
2020-08-13 20:01 ` Pierre-Louis Bossart [this message]
2020-08-13 20:01 ` [PATCH 16/21] ASoC: Intel: Skylake: skl-nhlt: remove redundant initialization Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 17/21] ASoC: Intel: Skylake: cldma: " Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 18/21] ASoC: Intel: Skylake: sst-utils: remove redundant assignment Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 19/21] ASoC: Intel: Skylake: skl-topology: remove redundant assignments Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 20/21] ASoC: Intel: Skylake: skl-topology: remove redundant assignment Pierre-Louis Bossart
2020-08-13 20:01 ` [PATCH 21/21] ASoC: Intel: Skylake: (cosmetic) align function parameters Pierre-Louis Bossart
2020-08-18 16:54 ` [PATCH 00/21] ASoC: Intel: fix cppcheck warnings Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813200147.61990-16-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).