From: Allen Pais <allen.cryptic@gmail.com>
To: perex@perex.cz, tiwai@suse.com, clemens@ladisch.de,
o-takashi@sakamocchi.jp, timur@kernel.org,
nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com
Cc: alsa-devel@alsa-project.org, keescook@chromium.org,
Allen Pais <allen.lkml@gmail.com>,
linux-kernel@vger.kernel.org,
Romain Perier <romain.perier@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 03/10] sound: asihpi: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 14:26:56 +0530 [thread overview]
Message-ID: <20200817085703.25732-4-allen.cryptic@gmail.com> (raw)
In-Reply-To: <20200817085703.25732-1-allen.cryptic@gmail.com>
From: Allen Pais <allen.lkml@gmail.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
sound/pci/asihpi/asihpi.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c
index 023c35a2a951..35e76480306e 100644
--- a/sound/pci/asihpi/asihpi.c
+++ b/sound/pci/asihpi/asihpi.c
@@ -921,10 +921,10 @@ static void snd_card_asihpi_timer_function(struct timer_list *t)
add_timer(&dpcm->timer);
}
-static void snd_card_asihpi_int_task(unsigned long data)
+static void snd_card_asihpi_int_task(struct tasklet_struct *t)
{
- struct hpi_adapter *a = (struct hpi_adapter *)data;
- struct snd_card_asihpi *asihpi;
+ struct snd_card_asihpi *asihpi = from_tasklet(asihpi, t, t);
+ struct hpi_adapter *a = asihpi->hpi;
WARN_ON(!a || !a->snd_card || !a->snd_card->private_data);
asihpi = (struct snd_card_asihpi *)a->snd_card->private_data;
@@ -2871,8 +2871,7 @@ static int snd_asihpi_probe(struct pci_dev *pci_dev,
if (hpi->interrupt_mode) {
asihpi->pcm_start = snd_card_asihpi_pcm_int_start;
asihpi->pcm_stop = snd_card_asihpi_pcm_int_stop;
- tasklet_init(&asihpi->t, snd_card_asihpi_int_task,
- (unsigned long)hpi);
+ tasklet_setup(&asihpi->t, snd_card_asihpi_int_task);
hpi->interrupt_callback = snd_card_asihpi_isr;
} else {
asihpi->pcm_start = snd_card_asihpi_pcm_timer_start;
--
2.17.1
next prev parent reply other threads:[~2020-08-17 9:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:56 [PATCH 00/10] sound: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17 8:56 ` [PATCH 01/10] sound: core: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17 8:56 ` [PATCH 02/10] sound: firewire: " Allen Pais
2020-08-17 8:56 ` Allen Pais [this message]
2020-08-17 8:56 ` [PATCH 04/10] sound: riptide: " Allen Pais
2020-08-17 8:56 ` [PATCH 05/10] sound: rm9652: " Allen Pais
2020-08-17 8:56 ` [PATCH 06/10] sound/soc: fsl_esai: " Allen Pais
2020-08-17 8:57 ` [PATCH 07/10] sound/soc: sh: " Allen Pais
2020-08-17 8:57 ` [PATCH 08/10] sound/soc: txx9: " Allen Pais
2020-08-17 8:57 ` [PATCH 09/10] sound: midi: " Allen Pais
2020-08-17 8:57 ` [PATCH 10/10] sound: ua101: " Allen Pais
2020-08-17 9:08 ` [PATCH 00/10] sound: convert tasklets to use new tasklet_setup() Takashi Iwai
2020-08-17 9:18 ` Allen Pais
2020-08-17 9:43 ` Takashi Iwai
2020-08-18 9:31 ` Allen
2020-08-18 10:25 ` Takashi Iwai
2020-08-18 10:44 ` Mark Brown
2020-08-18 10:59 ` Takashi Iwai
2020-08-19 10:51 ` Allen
2020-08-19 11:16 ` Mark Brown
2020-08-19 11:28 ` Takashi Iwai
2020-09-01 10:04 ` Allen
2020-09-01 10:09 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817085703.25732-4-allen.cryptic@gmail.com \
--to=allen.cryptic@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=romain.perier@gmail.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).