From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A2CDC433DF for ; Mon, 17 Aug 2020 11:48:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87BF42072E for ; Mon, 17 Aug 2020 11:48:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="uFzmBWzG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2Bb0s9c1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87BF42072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 09735168D; Mon, 17 Aug 2020 13:47:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 09735168D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597664913; bh=PWU1FA67zQAasUqd3BPumylawraXXdrgHP9MCo9WyJc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uFzmBWzGsG872eLP23P9OsEI258A4LXUM1UdqElnPomUuywpwAumJrp6s5nFkTWVL TvEpgGy/Ik3osQHQp+A9Zfp6I3SjsK/BCUqxhHKqnyXMq7Q5fIikrys1xHmWHg0b/U yVyrpXyiwCs7fOOVuePVcYHy1a3W0KEf5KW7R70I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 985EEF800EF; Mon, 17 Aug 2020 13:47:42 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E2C34F80218; Mon, 17 Aug 2020 13:47:41 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D3217F800F0 for ; Mon, 17 Aug 2020 13:47:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D3217F800F0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2Bb0s9c1" Received: from localhost (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C07AE20674; Mon, 17 Aug 2020 11:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597664853; bh=PWU1FA67zQAasUqd3BPumylawraXXdrgHP9MCo9WyJc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2Bb0s9c1fXzrj0yzxKH6TCjhWGcINNywtn7fDxCldvxcXqhjpd+ietw8xoQr1LBU4 +tId8AB1jrQEbVZDeJb458pPtVyNcCho0J3XN5oui0KxZzSSAUpgVTgwSfGcxehI18 juHydM2Zsdmrr3Rko36cqSQH8+J5gro0pUpgtS08= Date: Mon, 17 Aug 2020 17:17:29 +0530 From: Vinod Koul To: Bard Liao Subject: Re: [PATCH 09/13] soundwire: intel: add CLK_STOP_BUS_RESET support Message-ID: <20200817114729.GP2639@vkoul-mobl> References: <20200721203723.18305-1-yung-chuan.liao@linux.intel.com> <20200721203723.18305-10-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721203723.18305-10-yung-chuan.liao@linux.intel.com> Cc: pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, mengdong.lin@intel.com, slawomir.blauciak@intel.com, sanyog.r.kale@intel.com, rander.wang@linux.intel.com, bard.liao@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 22-07-20, 04:37, Bard Liao wrote: > From: Rander Wang > > Move existing pm_runtime suspend under the CLK_STOP_TEARDOWN case. > > In this mode the Master IP will lose all context but in-band wakes are > supported. > > On pm_runtime resume a complete re-enumeration will be performed after > a bus reset. > > Signed-off-by: Rander Wang > Signed-off-by: Pierre-Louis Bossart > Signed-off-by: Bard Liao > --- > drivers/soundwire/intel.c | 44 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index 1954eb48b86c..744fc0a4816a 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1576,6 +1576,26 @@ static int intel_suspend_runtime(struct device *dev) > > intel_shim_wake(sdw, false); > > + } else if (clock_stop_quirks & SDW_INTEL_CLK_STOP_BUS_RESET) { > + ret = sdw_cdns_clock_stop(cdns, true); > + if (ret < 0) { > + dev_err(dev, "cannot enable clock stop on suspend\n"); > + return ret; > + } > + > + ret = sdw_cdns_enable_interrupt(cdns, false); > + if (ret < 0) { > + dev_err(dev, "cannot disable interrupts on suspend\n"); > + return ret; > + } > + > + ret = intel_link_power_down(sdw); > + if (ret) { > + dev_err(dev, "Link power down failed: %d", ret); > + return ret; > + } no cleanup on all the error cases here? > + > + intel_shim_wake(sdw, true); > } else { > dev_err(dev, "%s clock_stop_quirks %x unsupported\n", > __func__, clock_stop_quirks); > @@ -1694,6 +1714,30 @@ static int intel_resume_runtime(struct device *dev) > dev_err(dev, "unable to exit bus reset sequence during resume\n"); > return ret; > } > + } else if (clock_stop_quirks & SDW_INTEL_CLK_STOP_BUS_RESET) { > + ret = intel_init(sdw); > + if (ret) { > + dev_err(dev, "%s failed: %d", __func__, ret); > + return ret; > + } > + > + /* > + * make sure all Slaves are tagged as UNATTACHED and > + * provide reason for reinitialization > + */ > + sdw_clear_slave_status(bus, SDW_UNATTACH_REQUEST_MASTER_RESET); > + > + ret = sdw_cdns_enable_interrupt(cdns, true); > + if (ret < 0) { > + dev_err(dev, "cannot enable interrupts during resume\n"); > + return ret; > + } > + > + ret = sdw_cdns_clock_restart(cdns, true); > + if (ret < 0) { > + dev_err(dev, "unable to restart clock during resume\n"); > + return ret; > + } > } else { > dev_err(dev, "%s clock_stop_quirks %x unsupported\n", > __func__, clock_stop_quirks); > -- > 2.17.1 -- ~Vinod