From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E5BC433DF for ; Tue, 25 Aug 2020 13:20:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70E9020639 for ; Tue, 25 Aug 2020 13:20:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="b/4+NpXm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70E9020639 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ACD07167D; Tue, 25 Aug 2020 15:19:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ACD07167D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598361625; bh=ASZVM7OkPe6315IX9Nh307CgulfRFzTSNjQnPUsim/Q=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=b/4+NpXmlJ00geHcubiMtV2kL8HCHNA3Bg2kNXIx5tOzO+gq0mehfw6FSu5pOUl8G WyVRDzTdbAiYWOXbUIDEGZq6HIlRsR+9NiAwjF6uRhVja4vgLBHtJktvw/JGcmTGK/ m9fqGHjCieIdyMfykbDgK1Ha7X4vJg9KWXN4Eoys= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 91450F80269; Tue, 25 Aug 2020 15:19:23 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0A0EFF80245; Tue, 25 Aug 2020 15:19:22 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AB4E2F80245 for ; Tue, 25 Aug 2020 15:19:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AB4E2F80245 IronPort-SDR: Ahf4MmR5bq4g/Y4BXr9ArUoSn89T8V/R2znmgZci+LBwmV6Qat12buIuwiR5PowXWLqBmc2zye /Ot3F4rwckgw== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="136163886" X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="136163886" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 06:19:12 -0700 IronPort-SDR: ubfPUGXIa1YKNzj5MxRoGywFsFs1KIgLJfBmirl+UUkwwzRcJE4qndjDX7AJcoeAti8MjIx74f eVPiFu9wT3rQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,352,1592895600"; d="scan'208";a="328861732" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 25 Aug 2020 06:19:08 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kAYqv-00BKaP-SW; Tue, 25 Aug 2020 16:19:05 +0300 Date: Tue, 25 Aug 2020 16:19:05 +0300 From: Andy Shevchenko To: Cezary Rojewski Subject: Re: [PATCH v4 01/13] ASoC: Intel: Add catpt device Message-ID: <20200825131905.GI1891694@smile.fi.intel.com> References: <20200812205753.29115-1-cezary.rojewski@intel.com> <20200812205753.29115-2-cezary.rojewski@intel.com> <20200813182908.GA1891694@smile.fi.intel.com> <3280b1a6-81f3-9f3f-d496-2bbf570c82d1@intel.com> <20200818100743.GH1891694@smile.fi.intel.com> <7cd5fa73-797e-17c3-4b7c-7635a18c59af@intel.com> <20200819134323.GM1891694@smile.fi.intel.com> <13a443ad-f667-c7f0-a25d-35baf94be23e@intel.com> <20200825131821.GH1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825131821.GH1891694@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, filip.kaczmarski@intel.com, harshapriya.n@intel.com, marcin.barlik@intel.com, zwisler@google.com, lgirdwood@gmail.com, tiwai@suse.com, filip.proborszcz@intel.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com, michal.wasko@intel.com, cujomalainey@chromium.org, krzysztof.hejmowski@intel.com, ppapierkowski@habana.ai, vamshi.krishna.gopal@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Aug 25, 2020 at 04:18:21PM +0300, Andy Shevchenko wrote: > On Tue, Aug 25, 2020 at 11:32:57AM +0200, Cezary Rojewski wrote: > > On 2020-08-19 3:43 PM, Andy Shevchenko wrote: > > > On Wed, Aug 19, 2020 at 03:26:04PM +0200, Cezary Rojewski wrote: ... > > > My vision is to extend that header to cover changes and use it in your code. > > > It might, though, require some cleanups to be done against pxa2xx_ssp.h. > > > > Conclusion from checking pxa2_ssp.h registers: > > > > - SSPSP2 is missing (0x44) > > - SSC2 vs SSACDD (0x40) both same offset but different purpose so probably > > new define would have to be added > > > > As situation is similar to the resource-API case below are the options: > > a) ship catpt with existing ssp reg set, update pxa2_ssp.h in following > > series and then re-use them for catpt > > b) update pxa2_ssp.h first, await merge, ship catpt only afterward > > > > I vote for option a) given the maturity driver is reaching plus I'd rather > > be done with sound/soc/intel/ sanitization sooner than later. > > Luckily we have Mark to maintain both SPI and ASoC, which means you may prepend > your series with PXA2xx header update and have his Ack for it. He can create an > immutable branch and apply it to SPI tree afterwards, or other way around. So I > definitely vote for b). Let's say "for b+)" mean the fast track of the changes to both subsystems. -- With Best Regards, Andy Shevchenko