From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B23C433E1 for ; Tue, 25 Aug 2020 19:19:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 251302071E for ; Tue, 25 Aug 2020 19:19:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="U4HQjfHP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 251302071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 86CD8168B; Tue, 25 Aug 2020 21:18:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 86CD8168B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598383159; bh=u0yt9nN7jC9w69HbJd62x6Z35R6lns7cJyBEEAs+5T8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=U4HQjfHPZKp63J1aRJpjSk1s1YGaZ/PASg+99QBefuEXtzTa/1pI58fPU03XtkQg7 qLhGN5O0w3+7ImJhPs1qndRMSgZ1VrLEazhFbAQb3mQKuT/9JlpQ1cR7p8kfxCDeYi bIizqOX5naFiIGmYWerclSD1r9As6U+kPo9SXj5w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 07092F80245; Tue, 25 Aug 2020 21:18:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EB3B9F8025A; Tue, 25 Aug 2020 21:18:27 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 54A30F800D1 for ; Tue, 25 Aug 2020 21:18:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 54A30F800D1 Received: by mail-io1-f66.google.com with SMTP id h4so13677836ioe.5 for ; Tue, 25 Aug 2020 12:18:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CbaB4dARNo7ofkMDOqGcoP4PrODHbcuDwxHGPmOw1BA=; b=DDkVsteH7G6Tluzk2RrMSDpyW6cs1SvyHh+ChiXTQCVagZ9WyGB+IDG3txoEOAjZON BEZw6nMUTskf+dfrWr+4WZ78dgS0QBWWKRBlBMYOCBmXKFWxyEdufXJsfD8m54vaU1cu SQvc5OKNHuVpv9QhQp2ceyeUUc6Ogo1jXiSFqdgvrNQA/rpT1mxYjeweHtLJH3Up9ic7 FR56Rk79f5Roy5Ekq8yG9cKvGtSmPgccg7PnDH6G0MDmmCTdRmqzwhrwWFH0JbVkJbGa DHbUgh7xfnYKmgB4Z7PW0qI00jHeBqPzBrMOctEJjVCHC+OZrBzYLYfLklXOsMejNxST 5dWg== X-Gm-Message-State: AOAM533D5FMMrgJf+KWu+sOYCc22uuyTRSg3iWQWFE5GjKC6PdccYeP+ ULHngA/9rJbTXtA/tx9gAQ== X-Google-Smtp-Source: ABdhPJyiuVhU4p4Zo1w9sz/+dYV7JwEuyuIWv7XvYB+aH6q7VTjJEiPzSYZ7YE7LmEn2epNgM4kg9A== X-Received: by 2002:a02:93c5:: with SMTP id z63mr2612135jah.122.1598383098433; Tue, 25 Aug 2020 12:18:18 -0700 (PDT) Received: from xps15 ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id l5sm9636540ilj.88.2020.08.25.12.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 12:18:17 -0700 (PDT) Received: (nullmailer pid 1158885 invoked by uid 1000); Tue, 25 Aug 2020 19:18:14 -0000 Date: Tue, 25 Aug 2020 13:18:14 -0600 From: Rob Herring To: Cheng-Yi Chiang Subject: Re: [PATCH v5 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings Message-ID: <20200825191814.GA1155274@bogus> References: <20200818035028.2265197-1-cychiang@chromium.org> <20200818035028.2265197-2-cychiang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818035028.2265197-2-cychiang@chromium.org> Cc: Taniya Das , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Banajit Goswami , Stephan Gerhold , Liam Girdwood , linux-arm-msm@vger.kernel.org, Patrick Lai , Takashi Iwai , linux-kernel@vger.kernel.org, tzungbi@chromium.org, Bjorn Andersson , Mark Brown , Rohit kumar , Andy Gross , dianders@chromium.org, Srini Kandagatla , dgreid@chromium.org, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Aug 18, 2020 at 11:50:27AM +0800, Cheng-Yi Chiang wrote: > Add devicetree bindings documentation file for sc7180 sound card. > > Signed-off-by: Cheng-Yi Chiang > --- > .../bindings/sound/qcom,sc7180.yaml | 127 ++++++++++++++++++ > 1 file changed, 127 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > new file mode 100644 > index 000000000000..b5cdaa0fe559 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > @@ -0,0 +1,127 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,sc7180.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver > + > +maintainers: > + - Rohit kumar > + - Cheng-Yi Chiang > + > +description: > + This binding describes the SC7180 sound card which uses LPASS for audio. > + > +properties: > + compatible: > + contains: Drop contains. Should be exactly the string listed. > + const: qcom,sc7180-sndcard > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + pair of strings, the first being the connection's sink, the second > + being the connection's source. > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + aux-dev: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle of the codec for headset detection > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^dai-link(@[0-9]+)?$": Unit addresses are hex. Do you really have more than 10? > + description: > + Each subnode represents a dai link. Subnodes of each dai links would be > + cpu/codec dais. > + > + type: object > + > + properties: > + link-name: > + description: Indicates dai-link name and PCM stream name. > + $ref: /schemas/types.yaml#/definitions/string > + maxItems: 1 > + > + reg: > + description: dai link address. > + $ref: /schemas/types.yaml#/definitions/uint32 reg already has a type. Drop. > + maxItems: 1 > + > + cpu: > + description: Holds subnode which indicates cpu dai. > + type: object > + properties: > + sound-dai: true > + > + codec: > + description: Holds subnode which indicates codec dai. > + type: object > + properties: > + sound-dai: true > + > + required: > + - link-name > + - cpu > + - codec > + > + additionalProperties: false > + > +required: > + - compatible > + - model > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false > + > +examples: > + > + - | > + sound { > + compatible = "qcom,sc7180-sndcard"; > + model = "sc7180-snd-card"; > + > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > + > + aux-dev = <&alc5682>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dai-link@0 { > + link-name = "MultiMedia0"; > + reg = <0>; > + cpu { > + sound-dai = <&lpass_cpu 0>; > + }; > + > + codec { > + sound-dai = <&alc5682 0>; > + }; > + }; > + > + dai-link@1 { > + link-name = "MultiMedia1"; > + reg = <1>; > + cpu { > + sound-dai = <&lpass_cpu 1>; > + }; > + > + codec { > + sound-dai = <&max98357a>; > + }; > + }; > + }; > -- > 2.28.0.220.ged08abb693-goog >