From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15AAEC433E1 for ; Wed, 26 Aug 2020 16:37:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82BC1206FA for ; Wed, 26 Aug 2020 16:37:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="sFVh9AOA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mO4JffxQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82BC1206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 10774177A; Wed, 26 Aug 2020 18:36:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 10774177A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598459838; bh=qrdU18lvM1hFnhmTD3louuy0mIUGuLG/l5x75RkizpA=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sFVh9AOAx7jlgJFUfeDEHCv8M2YX7VKzyLyMH2JHqndq9O9XSyxTFoOkquoIco0j7 UAEo0Hd0rFoqFHDoJLrL1yh++8kXPhoZJbucCzEHZECf6/ilCi9KFa46QQJxbAaGXb GfE5ojdoeQ7LkBUSfbTP9t2jZHvScLpmUGvRYal0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C30D5F802E2; Wed, 26 Aug 2020 18:34:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 37E1BF802C2; Wed, 26 Aug 2020 18:34:07 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 853B7F8016F for ; Wed, 26 Aug 2020 18:34:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 853B7F8016F Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mO4JffxQ" Received: from localhost.localdomain (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B522206FA; Wed, 26 Aug 2020 16:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598459639; bh=qrdU18lvM1hFnhmTD3louuy0mIUGuLG/l5x75RkizpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mO4JffxQQ09EMXsrmT0pqWPNRi9MRlrcgcYQ2NaaM+Z1rJztyj+syr0LgJL9XvQu8 bL+Z1HMMhrNb5GT5Ki+9LzOBDbMVuEb60ApfqSWqS1qWQqPmL8mnVdVXelCAuJX+gz U6Y4uKrh4AKg+PzdBdOibgED//7SHPL1D2bwr2Ms= From: Vinod Koul To: Mark Brown Subject: [PATCH v2 3/5] ASoC: rt711: Fix return check for devm_regmap_init_sdw() Date: Wed, 26 Aug 2020 22:03:38 +0530 Message-Id: <20200826163340.3249608-4-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200826163340.3249608-1-vkoul@kernel.org> References: <20200826163340.3249608-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Oder Chiou , Pierre-Louis Bossart , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, Takashi Iwai , Vinod Koul , Shuming Fan X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: 320b8b0d13b8 ("ASoC: rt711: add rt711 codec driver") Signed-off-by: Vinod Koul --- sound/soc/codecs/rt711-sdw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt711-sdw.c b/sound/soc/codecs/rt711-sdw.c index 45b928954b58..7efff130a638 100644 --- a/sound/soc/codecs/rt711-sdw.c +++ b/sound/soc/codecs/rt711-sdw.c @@ -452,8 +452,8 @@ static int rt711_sdw_probe(struct sdw_slave *slave, /* Regmap Initialization */ sdw_regmap = devm_regmap_init_sdw(slave, &rt711_sdw_regmap); - if (!sdw_regmap) - return -EINVAL; + if (IS_ERR(sdw_regmap)) + return PTR_ERR(sdw_regmap); regmap = devm_regmap_init(&slave->dev, NULL, &slave->dev, &rt711_regmap); -- 2.26.2