From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
jank@cadence.com, mengdong.lin@intel.com,
sanyog.r.kale@intel.com,
Bard Liao <yung-chuan.liao@linux.intel.com>,
rander.wang@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs
Date: Tue, 1 Sep 2020 16:37:16 +0530 [thread overview]
Message-ID: <20200901110716.GA2639@vkoul-mobl> (raw)
In-Reply-To: <051afb2d-dd2e-0ea4-d8a9-980f5df136b7@linux.intel.com>
On 31-08-20, 10:15, Pierre-Louis Bossart wrote:
>
> > > > > > > Detect cases where the clock is assumed to be stopped but the IP is
> > > > > > > not in the relevant state, and add a dynamic debug trace.
> > > > > >
> > > > > > you meant a debug print..and it looks like error print below (also in title).
> > > > >
> > > > > I don't understand the comment. Is the 'trace' confusing and are you asking
> > > > > to e.g. change the commit message to 'add dynamic debug log'?
> > > >
> > > > Question is what is dynamic about this?
> > > dev_dbg() is part of the kernel dynamic debug capability...
> > >
> > > https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html
> > >
> > > Not sure what you are asking here?
> >
> > :-| where is dev_dbg() ?
> >
> > See [1]
>
> >
> > [1]
> >
> > > + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__);
> >
> > ^^^^^^^
>
> it's still a log using the "dynamic debug" framework.
>
> Again, what are you asking us to fix?
Ah you are really testing my patience!
The title says "dynamic debug" and then you use a dev_err which is *not*
part of dynamic debug as it is printed always and cannot be dynamically
enabled and disabled!
See Documentation/admin-guide/dynamic-debug-howto.rst:
"Dynamic debug is designed to allow you to dynamically enable/disable
kernel code to obtain additional kernel information. Currently, if
``CONFIG_DYNAMIC_DEBUG`` is set, then all ``pr_debug()``/``dev_dbg()`` and
``print_hex_dump_debug()``/``print_hex_dump_bytes()`` calls can be dynamically
enabled per-callsite."
No dev_err here!
--
~Vinod
next prev parent reply other threads:[~2020-09-01 11:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 2:41 [PATCH 00/11] soundwire: intel: add multi-link support Bard Liao
2020-08-18 2:41 ` [PATCH 01/11] soundwire: intel: disable shim wake on suspend Bard Liao
2020-08-18 2:41 ` [PATCH 02/11] soundwire: intel: ignore software command retries Bard Liao
2020-08-18 2:41 ` [PATCH 03/11] soundwire: intel: add multi-link support Bard Liao
2020-08-18 2:41 ` [PATCH 04/11] soundwire: intel: add missing support for all clock stop modes Bard Liao
2020-08-18 2:41 ` [PATCH 05/11] soundwire: bus: update multi-link definition with hw sync details Bard Liao
2020-08-26 9:44 ` Vinod Koul
2020-08-26 14:09 ` Pierre-Louis Bossart
2020-08-28 7:27 ` Vinod Koul
2020-08-18 2:41 ` [PATCH 06/11] soundwire: intel: add multi-link hw_synchronization information Bard Liao
2020-08-18 2:41 ` [PATCH 07/11] soundwire: intel: Only call sdw stream APIs for the first cpu_dai Bard Liao
2020-08-26 9:46 ` Vinod Koul
2020-08-26 14:35 ` Pierre-Louis Bossart
2020-08-28 7:49 ` Vinod Koul
2020-08-28 1:47 ` Liao, Bard
2020-08-28 7:45 ` Vinod Koul
2020-08-28 15:07 ` Pierre-Louis Bossart
2020-08-18 2:41 ` [PATCH 08/11] soundwire: stream: enable hw_sync as needed by hardware Bard Liao
2020-08-18 2:41 ` [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs Bard Liao
2020-08-26 9:48 ` Vinod Koul
2020-08-26 14:38 ` Pierre-Louis Bossart
2020-08-28 7:49 ` Vinod Koul
2020-08-28 14:54 ` Pierre-Louis Bossart
2020-08-29 11:00 ` Vinod Koul
2020-08-31 15:15 ` Pierre-Louis Bossart
2020-09-01 11:07 ` Vinod Koul [this message]
2020-09-01 13:31 ` Pierre-Louis Bossart
2020-08-18 2:41 ` [PATCH 10/11] soundwire: intel: pass link_mask information to each master Bard Liao
2020-08-18 2:41 ` [PATCH 11/11] soundwire: intel: don't manage link power individually Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901110716.GA2639@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengdong.lin@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).