From: Mark Brown <broonie@kernel.org>
To: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: paul@pgazz.com, alsa-devel@alsa-project.org, jeho@cs.utexas.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fix kconfig dependency warnings for SND_SOC_WM8731
Date: Fri, 18 Sep 2020 14:32:02 +0100 [thread overview]
Message-ID: <20200918133202.GH5703@sirena.org.uk> (raw)
In-Reply-To: <20200918131257.5860-1-fazilyildiran@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Fri, Sep 18, 2020 at 04:12:58PM +0300, Necip Fazil Yildiran wrote:
> SND_SOC_WM8731 was made visible and dependent on other symbols with commit
> 1291e14175e6 ("ASoC: codecs: Make OF supported CODECs visible in Kconfig").
> To this respect, the symbols selecting SND_SOC_WM8731 turned out to be
> overlooking its dependencies.
> Switch reverse dependencies on SND_SOC_WM8731 to normal dependencies.
No, this is very user hostile - users shouldn't have to know exactly
which chips a given machine driver needs to figure out how to get the
config option visible. Please fix the selects in the machine driver
instead.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-09-18 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 13:12 [PATCH] ASoC: fix kconfig dependency warnings for SND_SOC_WM8731 Necip Fazil Yildiran
2020-09-18 13:32 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918133202.GH5703@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=fazilyildiran@gmail.com \
--cc=jeho@cs.utexas.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pgazz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).