From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB09AC43467 for ; Fri, 18 Sep 2020 13:54:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 245F020878 for ; Fri, 18 Sep 2020 13:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="V7KyFsJ1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 245F020878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 24B2316AF; Fri, 18 Sep 2020 15:53:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 24B2316AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600437244; bh=v8BUhtjbaVeS3c5zNpv0Lrfz3XhD85Ait1P58p4a/WU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=V7KyFsJ1gd5jj2DBii0GEy/U5tFCUAp34FCG6keAmwTXaUMCpitqRRSLJK6ZXMUWK sTSQoAz5KQONLTBTBKC6HUjKx3fsFEZAomlkcOzDP8NNOKs/jnA+4xCxjR/idcaaB8 CmdIbR/WZJPkOuzAceTa3Wa1OlxWGyGWNObyjmI0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A6D61F80150; Fri, 18 Sep 2020 15:53:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D9F0EF8015A; Fri, 18 Sep 2020 15:53:12 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1E9E8F8013A for ; Fri, 18 Sep 2020 15:53:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1E9E8F8013A IronPort-SDR: ulJu3ENPaYCiXjRIQEMC+p/Y7/FC3w1VF5nXK9pB7D8nrX7LztoucjcDV2GYlL0jO5E4NjC6v3 RBpyhyxIk0hA== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="159994234" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="159994234" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 06:52:56 -0700 IronPort-SDR: E+zL1FU9tWt/sGe4gw5lPRZklMzad8aUNWM0oQgKn2NA0p8xYuOCjs7LyQMjaGW94k/KYC5I0w kNz99184sEdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="336811479" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 18 Sep 2020 06:52:51 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kJGoi-0000CW-5I; Fri, 18 Sep 2020 16:52:48 +0300 Date: Fri, 18 Sep 2020 16:52:48 +0300 From: Andy Shevchenko To: "Rojewski, Cezary" Subject: Re: [PATCH v5 02/13] ASoC: Intel: catpt: Define DSP operations Message-ID: <20200918135248.GC3956970@smile.fi.intel.com> References: <20200915162944.16241-1-cezary.rojewski@intel.com> <20200915162944.16241-3-cezary.rojewski@intel.com> <20200916154409.GQ3956970@smile.fi.intel.com> <96ee725f1aa746c78ee380bb8e754ff3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96ee725f1aa746c78ee380bb8e754ff3@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: "pierre-louis.bossart@linux.intel.com" , "alsa-devel@alsa-project.org" , "Kaczmarski, Filip" , "N, Harshapriya" , "Barlik, Marcin" , "zwisler@google.com" , "lgirdwood@gmail.com" , "tiwai@suse.com" , "Proborszcz, Filip" , "broonie@kernel.org" , "amadeuszx.slawinski@linux.intel.com" , "Wasko, Michal" , "cujomalainey@chromium.org" , "Hejmowski, Krzysztof" , "Papierkowski, Piotr \(Habana\)" , "Gopal, Vamshi Krishna" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Sep 17, 2020 at 03:29:36PM +0000, Rojewski, Cezary wrote: > On 2020-09-16 5:44 PM, Andy Shevchenko wrote: > > On Tue, Sep 15, 2020 at 06:29:33PM +0200, Cezary Rojewski wrote: ... > >> + dmac->regs = cdev->lpe_ba + > >> + cdev->spec->host_dma_offset[CATPT_DMA_DEVID]; > > > > One line? > > > It's exactly 81 after one-lining - that's why I kept it as is. And 81 is okay when there is better readability. I'm wondering why you don't go 100... In any case it's not a reason to resend. -- With Best Regards, Andy Shevchenko