From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4497CC4363D for ; Wed, 7 Oct 2020 13:37:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BF77206DD for ; Wed, 7 Oct 2020 13:37:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="hckTI7au"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BWZaWTr0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BF77206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 72EA116B6; Wed, 7 Oct 2020 15:36:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 72EA116B6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1602077863; bh=MAeEvybVEoJRT6lc2sDnUP7WRyNeQfW3/IR19lxt3n0=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hckTI7auW0Af45ORmj447MwadC58eJkT0s697mPaDZuL2AdLEkkCd/TSBFeBC5Xfo ykka3q1mIldtVp0PZJLM8PvaXvsHsxe3cGCVkvs7xwq9F7FZDz/93EWGK/DzkVTcHY NFrhfsb2kktwQiSQ7x89lOIKK7ji+Q1UdsbfpVa8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 13BBBF80127; Wed, 7 Oct 2020 15:36:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EB37EF80128; Wed, 7 Oct 2020 15:36:51 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1254DF80087 for ; Wed, 7 Oct 2020 15:36:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1254DF80087 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BWZaWTr0" Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36ABC206DD; Wed, 7 Oct 2020 13:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602077798; bh=MAeEvybVEoJRT6lc2sDnUP7WRyNeQfW3/IR19lxt3n0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BWZaWTr08epBHl9vryIfizBSgAF/Ov+UNRxdscWjXcpcq6behdtjEZeXEYWySAksK x/uU7MM5ickJTP4tw3IbMpF7SN2aiSHWsmSzo/hbq0diLUmeiWbH7qBE3YrxGOy92L 2FrLTA+J9Es8X64gnA57vhZE3UCMfPqOlHzmopRA= Date: Wed, 7 Oct 2020 16:36:33 +0300 From: Leon Romanovsky To: "Saleem, Shiraz" Subject: Re: [PATCH v2 1/6] Add ancillary bus support Message-ID: <20201007133633.GB3964015@unreal> References: <20201005182446.977325-2-david.m.ertman@intel.com> <20201006071821.GI1874917@unreal> <20201006170241.GM1874917@unreal> <20201006172650.GO1874917@unreal> <3ff1445d86564ef3aae28d1d1a9a19ea@intel.com> <20201006192036.GQ1874917@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: "alsa-devel@alsa-project.org" , "kuba@kernel.org" , "parav@mellanox.com" , "tiwai@suse.de" , "netdev@vger.kernel.org" , Pierre-Louis Bossart , "ranjani.sridharan@linux.intel.com" , "fred.oh@linux.intel.com" , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" , "broonie@kernel.org" , Parav Pandit , Jason Gunthorpe , "gregkh@linuxfoundation.org" , "Ertman, David M" , "Williams, Dan J" , "davem@davemloft.net" , "Patil, Kiran" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Oct 07, 2020 at 01:09:55PM +0000, Saleem, Shiraz wrote: > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > > > On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote: > > > > > > On Tue, Oct 06, 2020 at 05:41:00PM +0000, Saleem, Shiraz wrote: > > > > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > > > > > > > > > On Tue, Oct 06, 2020 at 05:09:09PM +0000, Parav Pandit wrote: > > > > > > > > > > > > > From: Leon Romanovsky > > > > > > > Sent: Tuesday, October 6, 2020 10:33 PM > > > > > > > > > > > > > > On Tue, Oct 06, 2020 at 10:18:07AM -0500, Pierre-Louis Bossart wrote: > > > > > > > > Thanks for the review Leon. > > > > > > > > > > > > > > > > > > Add support for the Ancillary Bus, ancillary_device and > > ancillary_driver. > > > > > > > > > > It enables drivers to create an ancillary_device and > > > > > > > > > > bind an ancillary_driver to it. > > > > > > > > > > > > > > > > > > I was under impression that this name is going to be changed. > > > > > > > > > > > > > > > > It's part of the opens stated in the cover letter. > > > > > > > > > > > > > > ok, so what are the variants? > > > > > > > system bus (sysbus), sbsystem bus (subbus), crossbus ? > > > > > > Since the intended use of this bus is to > > > > > > (a) create sub devices that represent 'functional separation' > > > > > > and > > > > > > (b) second use case for subfunctions from a pci device, > > > > > > > > > > > > I proposed below names in v1 of this patchset. > > > > > > > > > > > (a) subdev_bus > > > > > > > > > > It sounds good, just can we avoid "_" in the name and call it subdev? > > > > > > > > > > > > > What is wrong with naming the bus 'ancillary bus'? I feel it's a fitting name. > > > > An ancillary software bus for ancillary devices carved off a parent device > > registered on a primary bus. > > > > > > Greg summarized it very well, every internal conversation about this > > > patch with my colleagues (non-english speakers) starts with the question: > > > "What does ancillary mean?" > > > https://lore.kernel.org/alsa-devel/20201001071403.GC31191@kroah.com/ > > > > > > "For non-native english speakers this is going to be rough, given that > > > I as a native english speaker had to go look up the word in a > > > dictionary to fully understand what you are trying to do with that > > > name." > > > > I suggested "auxiliary" in another splintered thread on this question. > > In terms of what the kernel is already using: > > > > $ git grep auxiliary | wc -l > > 507 > > $ git grep ancillary | wc -l > > 153 > > > > Empirically, "auxiliary" is more common and closely matches the intended function > > of these devices relative to their parent device. > > auxiliary bus is a befitting name as well. Let's share all options and decide later. I don't want to find us bikeshedding about it. Thanks