From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C051C4363A for ; Tue, 27 Oct 2020 17:52:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F13C24181 for ; Tue, 27 Oct 2020 17:52:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Y5YsHy/g"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="pZavBYKn"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="UfPHz7w8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F13C24181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8DB371683; Tue, 27 Oct 2020 18:51:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8DB371683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603821127; bh=kPMv8+Zh/KORhD0njYgb8hgRSSw25d4PaOM70L8xwDI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y5YsHy/gj629KijyRz1Wkdhb4vUjtHmG7FeliKlELGOrHFmWHeDrupOJ50npqcwDl AyQ9Xuz5Nj+wHBn95uFue4Zv71fo+RAGg5g1JOS5Xd0+TxY5t5z0dACoq7HhzaK69l vJMxUKGHqj1Uj3pOEJIPXdlDS05uX2a8z2/V3iCU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4C30CF8021D; Tue, 27 Oct 2020 18:50:39 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8552FF80274; Tue, 27 Oct 2020 18:50:37 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BB24AF8021D for ; Tue, 27 Oct 2020 18:50:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BB24AF8021D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="pZavBYKn"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="UfPHz7w8" Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id BBAA758042B; Tue, 27 Oct 2020 13:50:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 27 Oct 2020 13:50:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=kPMv8+Zh/KORhD0njYgb8hgRSSw 25d4PaOM70L8xwDI=; b=pZavBYKnU6QF++QvfUtkZbvkk3P6HwQ7RgBfrXlRTj2 ihaY2pqIXFyVR/3c0j3m0XxqGhdTshoXx03rZsY6vEmi7SADFoEluUvHevMcGV/R /NyzuD4ulB2zeAE3dU3oMZ+QwgLEZRQuMpGg9vl07CgxfhYYeBAi2UVlSi6mH4A9 srxmcWGGMwneP0lanBI7CdrXos7a33YvU4BSf31P18VAjgZg29pIqzpHzb2HPIG6 9s4VEXylVtWrjdVJJ2yL0yFuF9yZvxUJTeES7v/ApeqrOpqcwhNC3Peo5FKMip/j 6W9jG1oolzdTSVq1KYvLvoF9HtEcpdIpg8TetBPzYog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=kPMv8+ Zh/KORhD0njYgb8hgRSSw25d4PaOM70L8xwDI=; b=UfPHz7w8O+SL/X1bbZLia3 sfk6aQQoDswyqW2Jctbo/nCS5EnpBVCfqDuhZdJ2p/TIkpxgBNa/OO2or4PI2xHI EQbISu/jUrr90WO7333EdYrHiqElYLZ7SWtSLThx3zJUm3p1wvrd0USN23saETRo 4CHq5MPHYu1KFumHHw6//p5iq++sJzsYuFdVDRwO+SJLNjrVmMfn5UC9pVwV0Z9Z 4X7JNSJD8iKlOWirQe9Iz8c1ffEJLBqwE48USHTcFm9QtWlcGgsRQNsg8taso1Mm TDnNXO6AhKmNxVtBQGlyNaftBlsQQXHBDNSQG91bV1MDSVVD+veCiA43KxmG9epw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeelgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepuddvudfhkeekhefgffetffelgffftdehffduffegveetffehueeivddvjedv gfevnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 2CEBF306467E; Tue, 27 Oct 2020 13:50:33 -0400 (EDT) Date: Tue, 27 Oct 2020 18:50:32 +0100 From: Maxime Ripard To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [PATCH v8 04/14] ASoC: sun4i-i2s: Set sign extend sample Message-ID: <20201027175032.utw23rtbds6fwrbw@gilmour.lan> References: <20201026185239.379417-1-peron.clem@gmail.com> <20201026185239.379417-5-peron.clem@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y7eb4ufvmwjptweo" Content-Disposition: inline In-Reply-To: <20201026185239.379417-5-peron.clem@gmail.com> Cc: devicetree@vger.kernel.org, Jernej Skrabec , alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , linux-sunxi@googlegroups.com, Takashi Iwai , Marcus Cooper , Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --y7eb4ufvmwjptweo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 26, 2020 at 07:52:29PM +0100, Cl=E9ment P=E9ron wrote: > From: Marcus Cooper >=20 > On the newer SoCs such as the H3 and A64 this is set by default > to transfer a 0 after each sample in each slot. However the A10 > and A20 SoCs that this driver was developed on had a default > setting where it padded the audio gain with zeros. >=20 > This isn't a problem while we have only support for 16bit audio > but with larger sample resolution rates in the pipeline then SEXT > bits should be cleared so that they also pad at the LSB. Without > this the audio gets distorted. >=20 > Set sign extend sample for all the sunxi generations even if they > are not affected. This will keep consistency and avoid relying on > default. >=20 > Signed-off-by: Marcus Cooper > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Cl=E9ment P=E9ron Acked-by: Maxime Ripard Maxime --y7eb4ufvmwjptweo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX5hd6AAKCRDj7w1vZxhR xZqpAP9enB//96j/jv0+jG66uQta3FVLXyXrsFR+yA3EJWQGlwEAqa2gc/mmLsQF O71Gw/GubfFkbyT8hscPCLiGcG3HxA4= =NGld -----END PGP SIGNATURE----- --y7eb4ufvmwjptweo--