Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests
@ 2020-11-16 17:51 Krzysztof Kozlowski
  2020-11-16 17:51 ` [PATCH 2/4] ASoC: sh: " Krzysztof Kozlowski
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-16 17:51 UTC (permalink / raw)
  To: Jerome Brunet, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Kevin Hilman, Neil Armstrong, Martin Blumenstingl,
	Olivier Moysan, Arnaud Pouliquen, Maxime Coquelin,
	Alexandre Torgue, Peter Ujfalusi, alsa-devel, linux-arm-kernel,
	linux-amlogic, linux-kernel, linux-stm32
  Cc: kernel test robot, Krzysztof Kozlowski

The Meson SoC sound drivers use Common Clock Framework thus they cannot
be built on platforms without it (e.g. compile test on MIPS with RALINK
and SOC_RT305X):

    /usr/bin/mips-linux-gnu-ld: sound/soc/meson/aiu-encoder-spdif.o: in function `aiu_encoder_spdif_startup':
    aiu-encoder-spdif.c:(.text+0x3a0): undefined reference to `clk_set_parent'
    /usr/bin/mips-linux-gnu-ld: sound/soc/meson/axg-tdm-formatter.o: in function `axg_tdm_formatter_event':
    (.text+0x7ec): undefined reference to `clk_set_parent'

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 sound/soc/meson/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/meson/Kconfig b/sound/soc/meson/Kconfig
index 363dc3b1bbe4..dd8a05e61f58 100644
--- a/sound/soc/meson/Kconfig
+++ b/sound/soc/meson/Kconfig
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 menu "ASoC support for Amlogic platforms"
-	depends on ARCH_MESON || COMPILE_TEST
+	depends on ARCH_MESON || COMPILE_TEST && COMMON_CLK
 
 config SND_MESON_AIU
 	tristate "Amlogic AIU"
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/4] ASoC: sh: depend on COMMON_CLK to fix compile tests
  2020-11-16 17:51 [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
@ 2020-11-16 17:51 ` Krzysztof Kozlowski
  2020-11-16 17:51 ` [PATCH 3/4] ASoC: stm: " Krzysztof Kozlowski
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-16 17:51 UTC (permalink / raw)
  To: Jerome Brunet, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Kevin Hilman, Neil Armstrong, Martin Blumenstingl,
	Olivier Moysan, Arnaud Pouliquen, Maxime Coquelin,
	Alexandre Torgue, Peter Ujfalusi, alsa-devel, linux-arm-kernel,
	linux-amlogic, linux-kernel, linux-stm32
  Cc: kernel test robot, Krzysztof Kozlowski

The SH4 FSI sound drivers use SuperH clocks thus they cannot be built on
platforms without proper clock support (e.g. compile test on MIPS with
RALINK and SOC_RT305X):

    /usr/bin/mips-linux-gnu-ld: sound/soc/sh/fsi.o: in function `fsi_clk_set_rate_external':
    fsi.c:(.text+0x2714): undefined reference to `clk_set_parent'

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 sound/soc/sh/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sh/Kconfig b/sound/soc/sh/Kconfig
index ef8a29b9f641..346c806ba390 100644
--- a/sound/soc/sh/Kconfig
+++ b/sound/soc/sh/Kconfig
@@ -23,6 +23,7 @@ config SND_SOC_SH4_SSI
 
 config SND_SOC_SH4_FSI
 	tristate "SH4 FSI support"
+	depends on SUPERH || COMMON_CLK
 	select SND_SIMPLE_CARD
 	help
 	  This option enables FSI sound support
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 3/4] ASoC: stm: depend on COMMON_CLK to fix compile tests
  2020-11-16 17:51 [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
  2020-11-16 17:51 ` [PATCH 2/4] ASoC: sh: " Krzysztof Kozlowski
@ 2020-11-16 17:51 ` Krzysztof Kozlowski
  2020-11-16 17:51 ` [PATCH 4/4] ASoC: ti: " Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-16 17:51 UTC (permalink / raw)
  To: Jerome Brunet, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Kevin Hilman, Neil Armstrong, Martin Blumenstingl,
	Olivier Moysan, Arnaud Pouliquen, Maxime Coquelin,
	Alexandre Torgue, Peter Ujfalusi, alsa-devel, linux-arm-kernel,
	linux-amlogic, linux-kernel, linux-stm32
  Cc: kernel test robot, Krzysztof Kozlowski

The STM32 I2S drivers use Common Clock Framework thus they cannot be
built on platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):

    /usr/bin/mips-linux-gnu-ld: sound/soc/stm/stm32_i2s.o: in function `stm32_i2s_hw_params':
    stm32_i2s.c:(.text+0x1870): undefined reference to `clk_set_parent'

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 sound/soc/stm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig
index bbade257fe89..da1f7a16605b 100644
--- a/sound/soc/stm/Kconfig
+++ b/sound/soc/stm/Kconfig
@@ -15,6 +15,7 @@ config SND_SOC_STM32_SAI
 config SND_SOC_STM32_I2S
 	tristate "STM32 I2S interface (SPI/I2S block) support"
 	depends on (ARCH_STM32 && OF) || COMPILE_TEST
+	depends on COMMON_CLK
 	depends on SND_SOC
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 4/4] ASoC: ti: depend on COMMON_CLK to fix compile tests
  2020-11-16 17:51 [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
  2020-11-16 17:51 ` [PATCH 2/4] ASoC: sh: " Krzysztof Kozlowski
  2020-11-16 17:51 ` [PATCH 3/4] ASoC: stm: " Krzysztof Kozlowski
@ 2020-11-16 17:51 ` Krzysztof Kozlowski
  2020-11-23 20:40 ` [PATCH 1/4] ASoC: meson: " Mark Brown
  2020-11-23 21:46 ` Mark Brown
  4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-16 17:51 UTC (permalink / raw)
  To: Jerome Brunet, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Kevin Hilman, Neil Armstrong, Martin Blumenstingl,
	Olivier Moysan, Arnaud Pouliquen, Maxime Coquelin,
	Alexandre Torgue, Peter Ujfalusi, alsa-devel, linux-arm-kernel,
	linux-amlogic, linux-kernel, linux-stm32
  Cc: kernel test robot, Krzysztof Kozlowski

The TI/OMAP sound drivers use Common Clock Framework thus they cannot be
built on platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):

    /usr/bin/mips-linux-gnu-ld: sound/soc/ti/davinci-mcasp.o:davinci-mcasp.c:(.text+0x1c64): more undefined references to `clk_set_parent' follow
    /usr/bin/mips-linux-gnu-ld: sound/soc/ti/omap-dmic.o: in function `omap_dmic_set_dai_sysclk':
    omap-dmic.c:(.text+0xa5c): undefined reference to `clk_get_parent'

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 sound/soc/ti/Kconfig | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig
index 9775393d46b6..698d7bc84dcf 100644
--- a/sound/soc/ti/Kconfig
+++ b/sound/soc/ti/Kconfig
@@ -26,6 +26,7 @@ config SND_SOC_DAVINCI_ASP
 
 config SND_SOC_DAVINCI_MCASP
 	tristate "Multichannel Audio Serial Port (McASP) support"
+	depends on COMMON_CLK
 	select SND_SOC_TI_EDMA_PCM
 	select SND_SOC_TI_SDMA_PCM
 	select SND_SOC_TI_UDMA_PCM
@@ -47,7 +48,7 @@ config SND_SOC_DAVINCI_VCIF
 
 config SND_SOC_OMAP_DMIC
 	tristate "Digital Microphone Module (DMIC) support"
-	depends on ARCH_OMAP4 || SOC_OMAP5 || COMPILE_TEST
+	depends on ARCH_OMAP4 || SOC_OMAP5 || COMPILE_TEST && COMMON_CLK
 	select SND_SOC_TI_SDMA_PCM
 	help
 	  Say Y or M here if you want to have support for DMIC IP found in
@@ -55,7 +56,7 @@ config SND_SOC_OMAP_DMIC
 
 config SND_SOC_OMAP_MCBSP
 	tristate "Multichannel Buffered Serial Port (McBSP) support"
-	depends on ARCH_OMAP || ARCH_OMAP1 || COMPILE_TEST
+	depends on ARCH_OMAP || ARCH_OMAP1 || COMPILE_TEST && COMMON_CLK
 	select SND_SOC_TI_SDMA_PCM
 	help
 	  Say Y or M here if you want to have support for McBSP IP found in
@@ -99,7 +100,7 @@ config SND_SOC_OMAP3_PANDORA
 
 config SND_SOC_OMAP3_TWL4030
 	tristate "SoC Audio support for OMAP3 based boards with twl4030 codec"
-	depends on ARCH_OMAP3 || COMPILE_TEST
+	depends on ARCH_OMAP3 || COMPILE_TEST && COMMON_CLK
 	depends on TWL4030_CORE
 	select SND_SOC_OMAP_MCBSP
 	select SND_SOC_TWL4030
@@ -221,7 +222,7 @@ config SND_SOC_DM365_VOICE_CODEC_MODULE
 
 config SND_SOC_J721E_EVM
 	tristate "SoC Audio support for j721e EVM"
-	depends on ARCH_K3 || COMPILE_TEST
+	depends on ARCH_K3 || COMPILE_TEST && COMMON_CLK
 	depends on I2C
 	select SND_SOC_PCM3168A_I2C
 	select SND_SOC_DAVINCI_MCASP
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests
  2020-11-16 17:51 [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2020-11-16 17:51 ` [PATCH 4/4] ASoC: ti: " Krzysztof Kozlowski
@ 2020-11-23 20:40 ` Mark Brown
  2020-11-23 21:46 ` Mark Brown
  4 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-11-23 20:40 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: alsa-devel, Liam Girdwood, Olivier Moysan, Alexandre Torgue,
	Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
	Arnaud Pouliquen, Takashi Iwai, Peter Ujfalusi,
	kernel test robot, Maxime Coquelin, linux-amlogic, linux-kernel,
	linux-stm32, linux-arm-kernel, Jerome Brunet


[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

On Mon, Nov 16, 2020 at 06:51:30PM +0100, Krzysztof Kozlowski wrote:
> The Meson SoC sound drivers use Common Clock Framework thus they cannot
> be built on platforms without it (e.g. compile test on MIPS with RALINK
> and SOC_RT305X):

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests
  2020-11-16 17:51 [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
                   ` (3 preceding siblings ...)
  2020-11-23 20:40 ` [PATCH 1/4] ASoC: meson: " Mark Brown
@ 2020-11-23 21:46 ` Mark Brown
  4 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2020-11-23 21:46 UTC (permalink / raw)
  To: linux-kernel, Neil Armstrong, Takashi Iwai, Peter Ujfalusi,
	Krzysztof Kozlowski, Maxime Coquelin, alsa-devel,
	Jaroslav Kysela, Alexandre Torgue, Olivier Moysan, Liam Girdwood,
	Kevin Hilman, linux-arm-kernel, Arnaud Pouliquen, linux-amlogic,
	Martin Blumenstingl, Jerome Brunet, linux-stm32
  Cc: kernel test robot

On Mon, 16 Nov 2020 18:51:30 +0100, Krzysztof Kozlowski wrote:
> The Meson SoC sound drivers use Common Clock Framework thus they cannot
> be built on platforms without it (e.g. compile test on MIPS with RALINK
> and SOC_RT305X):
> 
>     /usr/bin/mips-linux-gnu-ld: sound/soc/meson/aiu-encoder-spdif.o: in function `aiu_encoder_spdif_startup':
>     aiu-encoder-spdif.c:(.text+0x3a0): undefined reference to `clk_set_parent'
>     /usr/bin/mips-linux-gnu-ld: sound/soc/meson/axg-tdm-formatter.o: in function `axg_tdm_formatter_event':
>     (.text+0x7ec): undefined reference to `clk_set_parent'

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests
      (no commit info)
[2/4] ASoC: sh: depend on COMMON_CLK to fix compile tests
      commit: c3d900dc905b78788c94f3a063b769bdbad16a98
[3/4] ASoC: stm: depend on COMMON_CLK to fix compile tests
      commit: 82ceffce96336ee9863f3dfde63aef5748ca4ab1
[4/4] ASoC: ti: depend on COMMON_CLK to fix compile tests
      commit: b3cf78e0dacb7fba50d0c1eb9dfa6f92d31529e2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 17:51 [PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
2020-11-16 17:51 ` [PATCH 2/4] ASoC: sh: " Krzysztof Kozlowski
2020-11-16 17:51 ` [PATCH 3/4] ASoC: stm: " Krzysztof Kozlowski
2020-11-16 17:51 ` [PATCH 4/4] ASoC: ti: " Krzysztof Kozlowski
2020-11-23 20:40 ` [PATCH 1/4] ASoC: meson: " Mark Brown
2020-11-23 21:46 ` Mark Brown

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git