alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* duplicate line at samsung speyside driver
@ 2021-01-21  4:09 Kuninori Morimoto
  2021-01-21 12:29 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Kuninori Morimoto @ 2021-01-21  4:09 UTC (permalink / raw)
  To: Mark Brown; +Cc: Linux-ALSA


Hi ALSA ML

I noticed samsung speyside driver has duplicate line on audio_paths.
I think it is typo or something...

	linux/sound/soc/samsung/speyside.c

	static struct snd_soc_dapm_route audio_paths[] = {
=>		{ "IN1RN", NULL, "MICB1" },
		{ "IN1RP", NULL, "MICB1" },
		{ "IN1RN", NULL, "MICB2" },
		{ "IN1RP", NULL, "MICB2" },
		{ "MICB1", NULL, "Headset Mic", speyside_get_micbias },
		{ "MICB2", NULL, "Headset Mic", speyside_get_micbias },

		{ "IN1LP", NULL, "MICB2" },
=>		{ "IN1RN", NULL, "MICB1" },
		{ "MICB2", NULL, "Main AMIC" },
		...

Thank you for your help !!

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: duplicate line at samsung speyside driver
  2021-01-21  4:09 duplicate line at samsung speyside driver Kuninori Morimoto
@ 2021-01-21 12:29 ` Mark Brown
  2021-01-21 23:20   ` Kuninori Morimoto
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2021-01-21 12:29 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Linux-ALSA

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

On Thu, Jan 21, 2021 at 01:09:18PM +0900, Kuninori Morimoto wrote:

> I noticed samsung speyside driver has duplicate line on audio_paths.
> I think it is typo or something...

Yes, that looks like a mistake.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: duplicate line at samsung speyside driver
  2021-01-21 12:29 ` Mark Brown
@ 2021-01-21 23:20   ` Kuninori Morimoto
  0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2021-01-21 23:20 UTC (permalink / raw)
  To: Mark Brown; +Cc: Linux-ALSA


Hi Mark

> > I noticed samsung speyside driver has duplicate line on audio_paths.
> > I think it is typo or something...
> 
> Yes, that looks like a mistake.

But I don't know what it should be.
I hope someone fix it with below tag.

	Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-21 23:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21  4:09 duplicate line at samsung speyside driver Kuninori Morimoto
2021-01-21 12:29 ` Mark Brown
2021-01-21 23:20   ` Kuninori Morimoto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).