From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73461C433E0 for ; Mon, 1 Feb 2021 10:28:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0ED8A64E11 for ; Mon, 1 Feb 2021 10:28:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ED8A64E11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0F8711714; Mon, 1 Feb 2021 11:27:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0F8711714 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612175296; bh=PS8IJ5JvjZuy5zHzMyJ9YXXpfetmK358icWc9qRWdAg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FzEXNMWdOsnQyeY43PYqwJuz1ZZFL5p0qVSo1x4FhAd1tNOJPo/WEmwfLYptZowZk GBsgZkRlG1460GsAkhU1AmtEHjV58dmW4/LcTNEwKsgyLQNeHiu89LnlbURdRHli7/ LRbIp4m0vsK7eSDnZTpywCqkRg+0LXCSEP367SuA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 954D5F80152; Mon, 1 Feb 2021 11:27:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 341ECF80154; Mon, 1 Feb 2021 11:27:24 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BF7DBF80151 for ; Mon, 1 Feb 2021 11:27:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BF7DBF80151 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iXgHbP3b" Received: by mail.kernel.org (Postfix) with ESMTPSA id 295D764E0F; Mon, 1 Feb 2021 10:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612175235; bh=PS8IJ5JvjZuy5zHzMyJ9YXXpfetmK358icWc9qRWdAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iXgHbP3by/cp7VCm81uh8jumovxCHj/+brOghZuWOvNupn7obmdzp36kPwTY/j0ll SenD7VNR2YLA/Ag2uCeBfkzvEXrrbFYGQNjK+W07dhHLF/6kmo4aKr/be7ikDehI/6 dp8a8DKuFWcx6sWuKBsEjs+u/RDWMUsd46aAiKZMgz4ZYUQhwSZ6qcaVQcK1iexoR3 Ag/iEkHozCodKArXpr9U9OtrUOjq5xc47KDzJfvO4KnNDUjHTgmFn3FMfeyn/+FCQ0 XINdU4TMDfCR94Qhywdjq1RDN/rqiCHF+jPgcXC06mbp09Ib8+Vn315YFX9ldi3aiI knzPiObvyzObw== Date: Mon, 1 Feb 2021 15:57:09 +0530 From: Vinod Koul To: Srinivas Kandagatla Subject: Re: [RFC PATCH 1/2] soundwire: add support for static port mapping Message-ID: <20210201102709.GT2771@vkoul-mobl> References: <9a688b02-80a6-fb1f-d6fa-36ba2d88d3b9@linux.intel.com> <3ee60ad9-9635-649e-ba67-d40a96b25256@linux.intel.com> <487c91f9-f6ea-75c2-9150-52db2de42a3a@linaro.org> <31ff9d2b-760a-374e-5b37-45d8e8116f7b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31ff9d2b-760a-374e-5b37-45d8e8116f7b@linaro.org> Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org, Pierre-Louis Bossart , linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 25-01-21, 16:23, Srinivas Kandagatla wrote: > > > On 22/01/2021 16:42, Pierre-Louis Bossart wrote: > > > > > > > > if you completely remove the stream and re-add it with updated > > > > configuration things should work. > > > > > > That's exactly what we do currently! > > > > > > The updated ports due to new configuration ex: for "mic capture" > > > dailink needs to be communicated from slave(codec) to master so that > > > it can allocate correct ports. That is what this patch is trying to > > > do (share current port map information). > > > > .. we have a disconnect on how to do this configuration update. > > > > The 'stream' support was designed so that a stream can be split across > > multiple devices (both masters and slaves). With this design we need to > > have a central configuration and distribute the information to all > > devices taking part of the stream. That is correct, but in this case a stream consists of one master and one or more slave devices. This is not a multi-master design. The adding of multiple masters should not be done here... that does not seem logically right in this situation > > It seems you are in a different solution-space, where the codec driver > > needs to notify the master of which ports it needs to use? > > Correct! As Codec is the place where we have mixer controls ant it can > clearly tell which master ports should be used for that particular > configuration. And that should come from firmware (DT etc) and driver should pass on this info > > I also don't see where the mapping is actually set. Patch 2 uses a > > mapping but there's no codec driver change that defines the mapping? > > > > Do you actually call sdw_stream_add_slave() with a new mapping? > > > Yes, currently am working on a codec driver for WCD938x Codec, which I will > posting very soon! > > > It feels we are missing the codec part to really see what you are trying > > to do? > My WIP code is at https://git.linaro.org/people/srinivas.kandagatla/linux.git/tree/sound/soc/codecs/wcd938x.c?h=wcd938x/wip#n4526 > > Currently the master ports are hardcoded in the driver for now, but these > will come from DT. > > --srini -- ~Vinod