From: kernel test robot <lkp@intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kbuild-all@lists.01.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v2 6/7] ASoC: codec: lpass-tx-macro: add support for lpass tx macro
Date: Wed, 10 Feb 2021 14:36:16 +0800 [thread overview]
Message-ID: <202102101439.GV6ErOfY-lkp@intel.com> (raw)
In-Reply-To: <20210208141719.23305-7-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3980 bytes --]
Hi Srinivas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/ASoC-codecs-add-support-for-LPASS-Codec-TX-and-RX-macros/20210209-084643
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: ia64-randconfig-r013-20210209 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4d44cfba08462d518a10d9d335287b19c2cbff02
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Srinivas-Kandagatla/ASoC-codecs-add-support-for-LPASS-Codec-TX-and-RX-macros/20210209-084643
git checkout 4d44cfba08462d518a10d9d335287b19c2cbff02
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
sound/soc/codecs/lpass-tx-macro.c: In function 'tx_macro_tx_hpf_corner_freq_callback':
>> sound/soc/codecs/lpass-tx-macro.c:656:15: warning: variable 'adc_n' set but not used [-Wunused-but-set-variable]
656 | u16 adc_reg, adc_n;
| ^~~~~
vim +/adc_n +656 sound/soc/codecs/lpass-tx-macro.c
647
648 static void tx_macro_tx_hpf_corner_freq_callback(struct work_struct *work)
649 {
650 struct delayed_work *hpf_delayed_work;
651 struct hpf_work *hpf_work;
652 struct tx_macro *tx;
653 struct snd_soc_component *component;
654 u16 dec_cfg_reg, hpf_gate_reg;
655 u8 hpf_cut_off_freq;
> 656 u16 adc_reg, adc_n;
657
658 hpf_delayed_work = to_delayed_work(work);
659 hpf_work = container_of(hpf_delayed_work, struct hpf_work, dwork);
660 tx = hpf_work->tx;
661 component = tx->component;
662 hpf_cut_off_freq = hpf_work->hpf_cut_off_freq;
663
664 dec_cfg_reg = CDC_TXn_TX_PATH_CFG0(hpf_work->decimator);
665 hpf_gate_reg = CDC_TXn_TX_PATH_SEC2(hpf_work->decimator);
666
667 if (is_amic_enabled(component, hpf_work->decimator)) {
668 adc_reg = CDC_TX_INP_MUX_ADC_MUXn_CFG0(hpf_work->decimator);
669 adc_n = snd_soc_component_read(component, adc_reg) &
670 CDC_TX_MACRO_SWR_MIC_MUX_SEL_MASK;
671 /* analog mic clear TX hold */
672 snd_soc_component_write_field(component,
673 dec_cfg_reg,
674 CDC_TXn_HPF_CUT_FREQ_MASK,
675 hpf_cut_off_freq);
676 snd_soc_component_update_bits(component, hpf_gate_reg,
677 CDC_TXn_HPF_F_CHANGE_MASK |
678 CDC_TXn_HPF_ZERO_GATE_MASK,
679 0x02);
680 snd_soc_component_update_bits(component, hpf_gate_reg,
681 CDC_TXn_HPF_F_CHANGE_MASK |
682 CDC_TXn_HPF_ZERO_GATE_MASK,
683 0x01);
684 } else {
685 snd_soc_component_write_field(component, dec_cfg_reg,
686 CDC_TXn_HPF_CUT_FREQ_MASK,
687 hpf_cut_off_freq);
688 snd_soc_component_write_field(component, hpf_gate_reg,
689 CDC_TXn_HPF_F_CHANGE_MASK, 0x1);
690 /* Minimum 1 clk cycle delay is required as per HW spec */
691 usleep_range(1000, 1010);
692 snd_soc_component_write_field(component, hpf_gate_reg,
693 CDC_TXn_HPF_F_CHANGE_MASK, 0x0);
694 }
695 }
696
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39234 bytes --]
next prev parent reply other threads:[~2021-02-10 6:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:17 [PATCH v2 0/7] ASoC: codecs: add support for LPASS Codec TX and RX macros Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 1/7] ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 2/7] ASoC: codec: lpass-rx-macro: add support for lpass rx macro Srinivas Kandagatla
2021-02-08 16:08 ` Mark Brown
2021-02-08 16:17 ` Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 3/7] ASoC: codec: lpass-rx-macro: add dapm widgets and route Srinivas Kandagatla
2021-02-09 6:34 ` kernel test robot
2021-02-08 14:17 ` [PATCH v2 4/7] ASoC: codec: lpass-rx-macro: add iir widgets Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 5/7] ASoC: qcom: dt-bindings: add bindings for lpass tx macro codec Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 6/7] ASoC: codec: lpass-tx-macro: add support for lpass tx macro Srinivas Kandagatla
2021-02-10 6:36 ` kernel test robot [this message]
2021-02-08 14:17 ` [PATCH v2 7/7] ASoC: codec: lpass-tx-macro: add dapm widgets and route Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102101439.GV6ErOfY-lkp@intel.com \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).