From: Hans de Goede <hdegoede@redhat.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Hans de Goede <hdegoede@redhat.com>,
alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Bard Liao <bard.liao@intel.com>
Subject: [PATCH alsa-ucm-conf 1/2] codecs/rt5672: Move +12dB input boost from 'STO1 ADC Boost Gain' to 'ADC Capture Volume'
Date: Wed, 17 Feb 2021 15:34:35 +0100 [thread overview]
Message-ID: <20210217143436.74209-1-hdegoede@redhat.com> (raw)
Both the 'STO1 ADC Boost Gain' and the 'ADC Capture Volume' controls are
digital and the 'ADC Capture Volume' control goes up to +30dB.
When adding hw-volume-control support adding the +12dB boost gain on to of
the max +30dB of 'ADC Capture Volume' is a bit too much.
So move the +12dB from the 'STO1 ADC Boost Gain' control to the
'ADC Capture Volume' control.
This way we keep the same setting for userspace which does not support
hw-volume-control, while getting a better range when we start using
'ADC Capture Volume' as hw-volume-control.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
ucm2/codecs/rt5672/EnableSeq.conf | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/ucm2/codecs/rt5672/EnableSeq.conf b/ucm2/codecs/rt5672/EnableSeq.conf
index ddfb1c7..e373275 100644
--- a/ucm2/codecs/rt5672/EnableSeq.conf
+++ b/ucm2/codecs/rt5672/EnableSeq.conf
@@ -26,14 +26,13 @@ EnableSequence [
# cset "name='LOUT MIX OUTMIX L Switch' on"
# cset "name='LOUT MIX OUTMIX R Switch' on"
- # 47=0dB, 0.375 dB/step
- cset "name='ADC Capture Volume' 47"
+ # Both the DMICs and the headset mic (even with the 20dB boost below)
+ # are quite soft, set the default capture volume to +12dB
+ # 47=0dB, 0.375dB/step, 79=+12dB
+ cset "name='ADC Capture Volume' 79"
cset "name='ADC Capture Switch' on"
-
- # Both the DMICs and the headset mic (even with the 20 dB boost below)
- # are quite soft, set the ADC Boost gain (range 0-3) to 1 = 12 dB the
- # next step is 24 dB which is a bit too much
- cset "name='STO1 ADC Boost Gain Volume' 1"
+ # 0=0dB
+ cset "name='STO1 ADC Boost Gain Volume' 0"
# Headset mic is quite soft, boost it a bit, 1 = 20dB which is the first
# available boost step
--
2.30.1
next reply other threads:[~2021-02-17 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 14:34 Hans de Goede [this message]
2021-02-17 14:34 ` [PATCH alsa-ucm-conf 2/2] codecs/rt5672: Add hardware volume-control support Hans de Goede
2021-03-13 15:47 ` [PATCH alsa-ucm-conf 1/2] codecs/rt5672: Move +12dB input boost from 'STO1 ADC Boost Gain' to 'ADC Capture Volume' Hans de Goede
2021-03-13 15:56 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217143436.74209-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).