From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: [PATCH 8/8] ASoC: sh: siu_pcm: remove unused variable
Date: Fri, 19 Feb 2021 17:16:35 -0600 [thread overview]
Message-ID: <20210219231635.5749-9-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210219231635.5749-1-pierre-louis.bossart@linux.intel.com>
cppcheck warning:
sound/soc/sh/siu_pcm.c:225:8: style: Variable 'virt' is assigned a
value that is never used. [unreadVariable]
virt = PERIOD_OFFSET(rt->dma_area,
^
It's not clear what this variable was needed for, remove it.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/sh/siu_pcm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/sound/soc/sh/siu_pcm.c b/sound/soc/sh/siu_pcm.c
index 6496300f73a9..0a8a3c314a73 100644
--- a/sound/soc/sh/siu_pcm.c
+++ b/sound/soc/sh/siu_pcm.c
@@ -217,14 +217,10 @@ static void siu_io_work(struct work_struct *work)
if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
dma_addr_t buff;
size_t count;
- u8 *virt;
buff = (dma_addr_t)PERIOD_OFFSET(rt->dma_addr,
siu_stream->cur_period,
siu_stream->period_bytes);
- virt = PERIOD_OFFSET(rt->dma_area,
- siu_stream->cur_period,
- siu_stream->period_bytes);
count = siu_stream->period_bytes;
/* DMA transfer start */
--
2.25.1
next prev parent reply other threads:[~2021-02-19 23:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 23:16 [PATCH 0/8] ASoC: sh: remove cppcheck warnings Pierre-Louis Bossart
2021-02-19 23:16 ` [PATCH 1/8] ASoC: sh: dma-sh7760: remove unused variable Pierre-Louis Bossart
2021-02-19 23:16 ` [PATCH 2/8] ASoC: sh: rcar: align function prototypes Pierre-Louis Bossart
2021-02-19 23:16 ` [PATCH 3/8] ASoC: sh: rcar: simplify return Pierre-Louis Bossart
2021-02-19 23:16 ` [PATCH 4/8] ASoC: sh: rcar: core: rename shadowing variables Pierre-Louis Bossart
2021-02-21 23:27 ` Kuninori Morimoto
2021-02-22 15:41 ` Pierre-Louis Bossart
2021-02-24 23:13 ` Kuninori Morimoto
2021-02-19 23:16 ` [PATCH 5/8] ASoC: sh: rcar: ctu: add missing error check Pierre-Louis Bossart
2021-02-19 23:16 ` [PATCH 6/8] ASoC: sh: rcar: ssi: remove redundant assignment Pierre-Louis Bossart
2021-02-19 23:16 ` [PATCH 7/8] ASoC: sh: siu_pcm: remove useless assignment Pierre-Louis Bossart
2021-02-19 23:16 ` Pierre-Louis Bossart [this message]
2021-02-21 23:32 ` [PATCH 0/8] ASoC: sh: remove cppcheck warnings Kuninori Morimoto
2021-03-01 23:34 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219231635.5749-9-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).