From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6DAC433DB for ; Mon, 22 Feb 2021 20:21:32 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF52E64E07 for ; Mon, 22 Feb 2021 20:21:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF52E64E07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D6039852; Mon, 22 Feb 2021 21:20:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D6039852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614025288; bh=IRinsFTIScAOT+Z3d/AgrlLMPmgST6R4mc7rA9DWmc4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sA9Xvxe+Tq/mtp8c6INQ8Ou+RdvrqOAT3ralPkXgmJ/tkwF0I4srbuwAJudak15V2 Qwc18eOMtnBgaXe48qvD97xlBodl8FAK40sfG28vCAPcVhbPD8pGL9ZEz3RZ/6HYxr 8BYSo/762wISgU9uRcHS8bGXKoM8MfE6rvu8f57w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 48710F80154; Mon, 22 Feb 2021 21:20:38 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 11E66F8016C; Mon, 22 Feb 2021 21:20:37 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6501BF800CE for ; Mon, 22 Feb 2021 21:20:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6501BF800CE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ks2WupQR" Received: by mail.kernel.org (Postfix) with ESMTPSA id 8978264DFD; Mon, 22 Feb 2021 20:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614025231; bh=IRinsFTIScAOT+Z3d/AgrlLMPmgST6R4mc7rA9DWmc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ks2WupQRVtufpv4xhoOqSKII42oju6II9zLB6s6kXAY2UZ//Mo2ch9giE67fTKpJl DS0xKhhkD6A4oJkhd2XBJxrWV5TDOV9AwYNvt/33yHrPiotTiKyIPzDmvES9He/tnX GhghXLhEuIrRUylHIWblR8MS7XZPexAPF7bh17CWgkH5s/NuQQJUj2etgcwBZ9rBHr MDfOh+jTIONTNztRljgrzQLwSuwTTKMkrIcDzwpL+p4Wqa5sJ8Kr9uW3S6g3MSdCbH uOmqUPMVB5qo81nvq7wAlk9Y4LdA12t4GBVXwb55/NZlewdpAuzuHlwyydJ8Z/Zddo 8cacJ97J5UoJw== Date: Mon, 22 Feb 2021 20:19:29 +0000 From: Mark Brown To: Krzysztof Kozlowski Subject: Re: (subset) [PATCH 0/6] ASoC: samsung: remove cppcheck warnings Message-ID: <20210222201929.GF6127@sirena.org.uk> References: <20210219230918.5058-1-pierre-louis.bossart@linux.intel.com> <161401004266.2538.5738460015320431431.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OzxllxdKGCiKxUZM" Content-Disposition: inline In-Reply-To: X-Cookie: A motion to adjourn is always in order. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: tiwai@suse.de, alsa-devel@alsa-project.org, Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --OzxllxdKGCiKxUZM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 22, 2021 at 06:31:15PM +0100, Krzysztof Kozlowski wrote: > Hmmm, I had comments about this one so it should not have been > applied. The check if (ret || !args.np) is still not good (or > confusing) because args is an uninitialized stack value. Ah, I saw the "this is actually a fix CC stable" bit, the bit saying there were issues was hidden - it looked like you'd just not deleted context. --OzxllxdKGCiKxUZM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA0EdAACgkQJNaLcl1U h9B79Af+OgeiU+jU8yAShBd7x2L39x1dQPspsU/HTwY/X0HG6JYXqnOkkyIWPC9V qFM17drHLEMi1c2XGkEYFsXwk8VB9QmjwqgAXeZPDdenh7Mt4eDPI1AhBLqFuCWd N2C6FeQMVxHGtW6Ih22kFyQYy/z1mpToaAHysc+Xz77RB4w+Xta0DBpxwCSd80Aj xO5Kf5rD2ZTjdxqXll7T9R0KipybP6uPmypeEIo73sVZeVvopHWAYb14geYTtC/Y cKkTW9G6SzajnxfXKqHiUSYtToioXRRsI7/9tAjym7HPrBfRzk+0/TL0CbA2DIfz qm0UnyZrwkjuZ/x12R/aLnBK4n7QpQ== =HMDX -----END PGP SIGNATURE----- --OzxllxdKGCiKxUZM--