From: Mark Brown <broonie@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Bard Liao <bard.liao@intel.com>
Subject: Re: [RFC 2/2] ASoC: rt5670: Add LED trigger support
Date: Tue, 23 Feb 2021 14:09:30 +0000 [thread overview]
Message-ID: <20210223140930.GH5116@sirena.org.uk> (raw)
In-Reply-To: <578b1ee3-f426-c5b5-bc78-5a91108ebdc8@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]
On Tue, Feb 23, 2021 at 02:59:17PM +0100, Hans de Goede wrote:
> On 2/23/21 2:45 PM, Mark Brown wrote:
> > On Mon, Feb 15, 2021 at 03:24:19PM +0100, Hans de Goede wrote:
> > Why just these particular controls - what if a system has separate mutes
> > for speakers or something?
> These are the main volume controls, which are always in the output / input
> path independent on if we are outputting to e.g. speakers or the headphones.
> We want to use the main volume control for this, because there always is
> only 1 output mute LED and 1 input mute LED. Well at least that is the assumption
> the current ledtrig-audio.c code has.
> The idea is to only turn the single LED on if we are sure there will be not
> sound output on any of the outputs, which is why we tie the LED to the
> mute switch on the main volume control.
Right, so that might work well on your particular system with your
particular configuration but will it work well on other systems with
different hardware? It's not clear to me that it makes sense to go
through all the drivers picking controls that might be used for this
purpose - it seems both time consuming and error prone. Consider a
mostly digital device which has an ADC/DAC per input/output rather than
a central ADC/DAC with analogue muxing for example, or a system with
multiple DACs available for mixing together or analogue bypassess.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-23 14:11 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 14:24 [RFC 0/2] ASoC: rt5670: Add LED trigger support Hans de Goede
2021-02-15 14:24 ` [RFC 1/2] ASoC: Add new SOC_DOUBLE*_ACCESS() macros Hans de Goede
2021-02-15 14:24 ` [RFC 2/2] ASoC: rt5670: Add LED trigger support Hans de Goede
2021-02-23 13:45 ` Mark Brown
2021-02-23 13:59 ` Hans de Goede
2021-02-23 14:09 ` Mark Brown [this message]
2021-02-23 14:21 ` Takashi Iwai
2021-02-23 16:14 ` Jaroslav Kysela
2021-02-23 16:20 ` Takashi Iwai
2021-02-23 20:56 ` Jaroslav Kysela
2021-02-24 7:12 ` Takashi Iwai
2021-02-24 8:14 ` Jaroslav Kysela
2021-02-24 8:52 ` Takashi Iwai
2021-02-24 9:27 ` Jaroslav Kysela
2021-02-24 9:38 ` Takashi Iwai
2021-02-24 9:49 ` Jaroslav Kysela
2021-02-24 10:33 ` Takashi Iwai
2021-02-24 10:56 ` Jaroslav Kysela
2021-02-24 11:43 ` Takashi Iwai
2021-02-24 12:08 ` Jaroslav Kysela
2021-02-24 12:42 ` Takashi Iwai
2021-02-24 17:57 ` Jaroslav Kysela
2021-02-25 11:00 ` Takashi Iwai
2021-02-25 18:09 ` Jaroslav Kysela
2021-02-26 8:41 ` Takashi Iwai
2021-02-26 9:22 ` Jaroslav Kysela
2021-02-23 17:07 ` Hans de Goede
2021-02-23 17:20 ` Mark Brown
2021-02-23 19:03 ` Hans de Goede
2021-02-24 12:59 ` Mark Brown
2021-02-24 19:14 ` Hans de Goede
2021-02-24 19:36 ` Mark Brown
2021-02-24 20:09 ` Hans de Goede
2021-02-25 14:59 ` Mark Brown
2021-02-25 18:45 ` Hans de Goede
2021-03-01 13:23 ` Mark Brown
2021-03-01 13:39 ` Hans de Goede
2021-03-01 19:15 ` Mark Brown
2021-03-01 19:49 ` Hans de Goede
2021-03-01 20:43 ` Mark Brown
2021-03-01 21:26 ` Hans de Goede
2021-03-02 12:41 ` Mark Brown
2021-03-02 21:14 ` Jaroslav Kysela
2021-03-04 19:39 ` Hans de Goede
2021-03-05 13:02 ` Jaroslav Kysela
2021-03-07 13:51 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223140930.GH5116@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).