From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE07C433E0 for ; Tue, 2 Mar 2021 13:06:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C31DD64F20 for ; Tue, 2 Mar 2021 13:06:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C31DD64F20 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9A47316EB; Tue, 2 Mar 2021 14:05:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9A47316EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614690364; bh=QSWRjXfZNLMdRfvCmLRy+mM6QNn398hcGSjjZz5fy+0=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NFzcwEyPgJ6GghZbAHerN9YrDcaiG/2LWm/Hbf/wEZHUORM4fg0qejay9gQ88Thvt eLfE9RpOC8WyM/yZH/lmsW/CheiItkjMNXsdLEdGM4eR0onvu7PcRn2e6/mZ1+egFE hXMJ/QdLhvFIejC9CRn5i3Oi9BYyc1jfAMMFPbic= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2ED4FF8012D; Tue, 2 Mar 2021 14:05:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B6B6DF80269; Tue, 2 Mar 2021 14:05:12 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42CE3F8012D for ; Tue, 2 Mar 2021 14:05:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42CE3F8012D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nr/hui3Z" Received: by mail.kernel.org (Postfix) with ESMTPSA id D49B964F0D; Tue, 2 Mar 2021 13:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614690307; bh=QSWRjXfZNLMdRfvCmLRy+mM6QNn398hcGSjjZz5fy+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nr/hui3ZtJHnRFcHg9P0HfaQWvcmXBAFGUdxjUELqb12qd+RhjnVFOltgZjgjCUlW jiYZRGZHJ1F9AI/YjPrpdKXPZ1Ox6uJ301zcIIVNcmG4oe6T6QkAoFvCNCENh0n+2x Nw0UZOqUgHw3RCAlP7WgOmzW0dge4KDtkgQbcOZgfjKj9J7mQbEulIQ8E48gzGmL7p DNq7YpncATONKl9XuePBWrE3k8UOvzyx+G1McY9k5DQtH6UDAIPhJKnKKzgIkqP+o+ zNXIVwLESdsB4YmJC+Y3QWu/rX5a0zVNbfv0w6Vxc1B3kH+Hq0Lclq5pURqgIDtNz3 F5t0DdAeRs2UQ== Date: Tue, 2 Mar 2021 13:04:00 +0000 From: Mark Brown To: Kuninori Morimoto Subject: Re: [PATCH 2/8] ASoC: soc-pcm: add soc_cpu/codec_dai_name() macro Message-ID: <20210302130400.GD4522@sirena.org.uk> References: <87tupuqqc8.wl-kuninori.morimoto.gx@renesas.com> <87r1kyqqb8.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MAH+hnPXVZWQ5cD/" Content-Disposition: inline In-Reply-To: <87r1kyqqb8.wl-kuninori.morimoto.gx@renesas.com> X-Cookie: Friction is a drag. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Linux-ALSA X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --MAH+hnPXVZWQ5cD/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 02, 2021 at 10:47:55AM +0900, Kuninori Morimoto wrote: > +#define soc_cpu_dai_name(rtd) \ > + (((rtd)->num_cpus == 1) ? asoc_rtd_to_cpu((rtd), 0)->name : "multicpu") > +#define soc_codec_dai_name(rtd) \ > + (((rtd)->num_codecs == 1) ? asoc_rtd_to_codec((rtd), 0)->name : "multicodec") I can't see any reason not to make these static inline functions instead? --MAH+hnPXVZWQ5cD/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA+N78ACgkQJNaLcl1U h9DfHwf/ZMYWs/sPWA+rzE0whXhFXg/fEfsHzSiUQsVcBbFvOxOjHIA7SeahVxh7 DWpNZrwnH/P3SyUeUEZJuDCA7yyq6kGaqfDAD5FUwoVb8dSx5CzKLtrEFNr+RtYc EjLcrwQyXPABC42gQ3R9wdQp6KJSAV4AB5CGcM3H/7AQgsLM3ZXRDZqKv74BNhoF vP+cXtvwinFAxfUiqj9nwIRDUtGrGwQZbYWJyqIpjjGmESvIWyFqc67sbhvQnPwo lDb1XyZeF+YInBG/mh4EePy/kTS+Q+Y6BGhLiDbsKPn0+ib6/yXEPZEaiCh20Zh7 AvUUfpmDhjoD/9ToRfOuxcSlOnxW1w== =G5Uc -----END PGP SIGNATURE----- --MAH+hnPXVZWQ5cD/--