alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	kuninori.morimoto.gx@renesas.com, robh@kernel.org,
	linux-kernel@vger.kernel.org, jonathanh@nvidia.com,
	sharadg@nvidia.com, Michael Walle <michael@walle.cc>,
	thierry.reding@gmail.com, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock
Date: Mon, 15 Mar 2021 15:39:25 +0000	[thread overview]
Message-ID: <20210315153925.GC4595@sirena.org.uk> (raw)
In-Reply-To: <6af6439c-bdb8-cd0f-635d-069040ba5b65@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

On Mon, Mar 15, 2021 at 08:49:00PM +0530, Sameer Pujar wrote:
> On 3/15/2021 5:35 PM, Michael Walle wrote:
> > Am 2021-03-12 14:46, schrieb Mark Brown:

> > Sameer, it looks like the proper fix should be to add the clock
> > support to your codec.

> I agree that complicated clock relationships should be handled within the
> codec itself, however MCLK rate setting depends on "mclk-fs" factor and this
> property is specified as part of simple-card/audio-graph-card codec subnode.
> Right now codec, in general, does not have a way to know this. The
> set_sysclk() callback takes rate argument and not the factor. Moreover the

I just don't understand what you're saying here at all.  At the point
where the card is setting the clock API clock rate it can just as well
set a sysclk, these are equivalent operations.

> same codec is used by other platform vendors too and unless a new DT
> property is added for codec, runtime MCLK update based on the scaling factor
> cannot be supported. This would mean that we will be having two methods to
> specify "mclk-fs" factor, one from simple-card/audio-graph-card and one from
> respective codec nodes, which does not seem ideal.

Again I just can't follow what you're saying here at all.  Again, if the
card is able to set a clock API clock rate it can just as well set a
clock rate via sysclk.

> Yes this is a problem, unfortunately I missed checking some of the
> simple-card examples. I wonder we should be specifically looking for "mclk"
> clock here.

That would definitely help mitigate the problem but I really think it's
cleaner and safer to just push this down to set_sysclk().

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2021-03-15 15:41 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  6:43 [PATCH 0/3] Use clocks property in a device node Sameer Pujar
2021-02-10  6:43 ` [PATCH 1/3] ASoC: simple-card-utils: Fix device module clock Sameer Pujar
2021-02-11 23:44   ` Kuninori Morimoto
2021-02-14 17:56     ` Sameer Pujar
2021-02-14 23:25       ` Kuninori Morimoto
2021-03-09 14:41   ` Michael Walle
2021-03-09 16:27     ` Sameer Pujar
2021-03-09 22:30       ` Michael Walle
2021-03-10 14:50         ` Sameer Pujar
2021-03-10 18:14           ` Michael Walle
2021-03-10 19:19             ` Sameer Pujar
2021-03-11 10:27           ` Michael Walle
2021-03-11 11:05             ` Sameer Pujar
2021-03-11 11:16               ` Michael Walle
2021-03-11 14:29                 ` Sameer Pujar
2021-03-11 15:43                   ` Michael Walle
2021-03-11 16:41                     ` Mark Brown
2021-03-11 16:15           ` Mark Brown
2021-03-11 22:11             ` Michael Walle
2021-03-12 11:35               ` Mark Brown
2021-03-12 12:01                 ` Michael Walle
2021-03-12 12:04                   ` Mark Brown
2021-03-12 12:30                     ` Michael Walle
2021-03-12 13:46                       ` Mark Brown
2021-03-15 12:05                         ` Michael Walle
2021-03-15 15:19                           ` Sameer Pujar
2021-03-15 15:33                             ` Michael Walle
2021-03-15 15:57                               ` Sameer Pujar
2021-03-15 15:39                             ` Mark Brown [this message]
2021-03-15 17:10                               ` Sameer Pujar
2021-03-15 17:13                                 ` Michael Walle
2021-03-11 16:00     ` Mark Brown
2021-03-11 21:34       ` Michael Walle
2021-02-10  6:43 ` [PATCH 2/3] Revert "ASoC: audio-graph-card: Add clocks property to endpoint node" Sameer Pujar
2021-02-11 13:00   ` Mark Brown
2021-02-10  6:43 ` [PATCH 3/3] arm64: tegra: Move clocks from RT5658 endpoint to device node Sameer Pujar
2021-02-11 15:38 ` [PATCH 0/3] Use clocks property in a " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315153925.GC4595@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=robh@kernel.org \
    --cc=sharadg@nvidia.com \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).