From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
Mark Brown <broonie@kernel.org>,
Jie Yang <yang.jie@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support
Date: Thu, 18 Mar 2021 11:43:10 +0000 [thread overview]
Message-ID: <20210318114310.GE2916463@dell> (raw)
In-Reply-To: <433cda84-2d61-ccb4-155a-5f8fa1021c90@redhat.com>
On Thu, 18 Mar 2021, Hans de Goede wrote:
> Hi Lee,
>
> On 3/7/21 4:17 PM, Hans de Goede wrote:
> > Hi All,
> >
> > Here is v4 of my series to rework the arizona codec jack-detect support
> > to use the snd_soc_jack helpers instead of direct extcon reporting.
> >
> > As discussed before here is a resend rebased on 5.12-rc2, making sure that
> > all patches this depends on are in place.
> >
> > Lee, can you pick-up patches 1-6 through the MFD tree and then send a
> > pull-req to Mark so that Mark can merge the Asoc parts throught the ASoC
> > tree ?
> >
> > Patches 2-6 touch drivers/extcon, these all have an Ack from Chanwoo Choi
> > for merging these through the MFD tree.
>
> Lee, is there a specific reason why these have not been merged yet,
> or did you just not get around to these yet ?
>
> As I already mentioned Chanwoo Choi already gave an ack for merging
> the extcon patches through MFD, so AFAICT eveything is ready to merge
> 1-6 through the MFD tree, and then have Mark merge an ib from the
> MFD tree and merge the rest.
I can't remember where we left it.
I guess I can take 1-6 (as suggested above) without issue.
Hold tight.
> > Here is some more generic info on this series from the previous
> > cover-letter:
> >
> > This is done by reworking the extcon driver into an arizona-jackdet
> > library and then modifying the codec drivers to use that directly,
> > replacing the old separate extcon child-devices and extcon-driver.
> >
> > This brings the arizona-codec jack-detect handling inline with how
> > all other ASoC codec driver do this. This was developed and tested on
> > a Lenovo Yoga Tablet 1051L with a WM5102 codec.
> >
> > This was also tested by Charles Keepax, one of the Cirrus Codec folks.
> >
> > Regards,
> >
> > Hans
> >
> >
> > Hans de Goede (13):
> > mfd: arizona: Drop arizona-extcon cells
> > extcon: arizona: Fix some issues when HPDET IRQ fires after the jack
> > has been unplugged
> > extcon: arizona: Fix various races on driver unbind
> > extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol")
> > call
> > extcon: arizona: Always use pm_runtime_get_sync() when we need the
> > device to be awake
> > ASoC/extcon: arizona: Move arizona jack code to
> > sound/soc/codecs/arizona-jack.c
> > ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv
> > ASoC: arizona-jack: Use arizona->dev for runtime-pm
> > ASoC: arizona-jack: convert into a helper library for codec drivers
> > ASoC: arizona-jack: Use snd_soc_jack to report jack events
> > ASoC: arizona-jack: Cleanup logging
> > ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use
> > the new jack library
> > ASoC: Intel: bytcr_wm5102: Add jack detect support
> >
> > MAINTAINERS | 3 +-
> > drivers/extcon/Kconfig | 8 -
> > drivers/extcon/Makefile | 1 -
> > drivers/mfd/arizona-core.c | 20 -
> > sound/soc/codecs/Makefile | 2 +-
> > .../soc/codecs/arizona-jack.c | 577 +++++++-----------
> > sound/soc/codecs/arizona.h | 44 ++
> > sound/soc/codecs/wm5102.c | 12 +-
> > sound/soc/codecs/wm5110.c | 12 +-
> > sound/soc/codecs/wm8997.c | 14 +-
> > sound/soc/codecs/wm8998.c | 9 +
> > sound/soc/intel/boards/bytcr_wm5102.c | 28 +-
> > 12 files changed, 325 insertions(+), 405 deletions(-)
> > rename drivers/extcon/extcon-arizona.c => sound/soc/codecs/arizona-jack.c (76%)
> >
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-03-18 11:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 15:17 [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support Hans de Goede
2021-03-07 15:17 ` [PATCH v4 resend 01/13] mfd: arizona: Drop arizona-extcon cells Hans de Goede
2021-03-07 15:17 ` [PATCH v4 resend 02/13] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged Hans de Goede
2021-03-07 15:17 ` [PATCH v4 resend 03/13] extcon: arizona: Fix various races on driver unbind Hans de Goede
2021-03-07 15:17 ` [PATCH v4 resend 04/13] extcon: arizona: Fix flags parameter to the gpiod_get("wlf, micd-pol") call Hans de Goede
2021-03-07 15:17 ` [PATCH v4 resend 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake Hans de Goede
2021-03-07 15:18 ` [PATCH v4 resend 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c Hans de Goede
2021-03-07 15:18 ` [PATCH v4 resend 07/13] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv Hans de Goede
2021-03-07 15:18 ` [PATCH v4 resend 08/13] ASoC: arizona-jack: Use arizona->dev for runtime-pm Hans de Goede
2021-03-07 15:18 ` [PATCH v4 resend 09/13] ASoC: arizona-jack: convert into a helper library for codec drivers Hans de Goede
2021-03-07 15:18 ` [PATCH v4 resend 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events Hans de Goede
2021-03-07 15:18 ` [PATCH v4 resend 11/13] ASoC: arizona-jack: Cleanup logging Hans de Goede
2021-03-07 15:18 ` [PATCH v4 resend 12/13] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library Hans de Goede
2021-03-07 15:18 ` [PATCH v4 resend 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support Hans de Goede
2021-03-18 11:24 ` [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support Hans de Goede
2021-03-18 11:43 ` Lee Jones [this message]
2021-03-22 14:40 ` [GIT PULL] Immutable branch between MFD and Extcon due for the v5.13 merge window Lee Jones
2021-03-22 14:54 ` Hans de Goede
2021-03-24 23:39 ` (subset) [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support Mark Brown
[not found] <CGME20210204112515epcas1p27a866811ba15a8cd8b0be9a3f7bf86e5@epcas1p2.samsung.com>
2021-02-04 11:24 ` Hans de Goede
2021-02-05 2:00 ` Chanwoo Choi
2021-02-05 10:27 ` Hans de Goede
2021-02-08 19:12 ` Hans de Goede
2021-02-09 14:14 ` Lee Jones
2021-02-09 14:52 ` Hans de Goede
2021-02-09 15:45 ` Lee Jones
2021-02-09 16:34 ` Hans de Goede
2021-02-09 16:44 ` Lee Jones
2021-02-10 19:57 ` Mark Brown
2021-02-11 8:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318114310.GE2916463@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).