alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Subject: [PATCH 00/11] ALSA: usx2y: Fixes and cleanups
Date: Mon, 17 May 2021 15:15:34 +0200	[thread overview]
Message-ID: <20210517131545.27252-1-tiwai@suse.de> (raw)

Hi,

this is a patch series for usx2y drivers.

Most part of changes are about cleanup of the code.  The current usx2y
driver is fairly unmaintained code, and this was the cause of some
overseen bugs (or rather confusion) as happened in UMN fiasco.

So the initial goal is to make a bit more readable for further
reviews.  The remaining part of changes are actual fixes.  At this
time, I concentrated only on the obvious issues that could be spotted
out after the cleanup.  The driver is likely broken in other ways, but
the identification and the fix would need the actual device, so I
leave them for now.


Takashi

===

Takashi Iwai (11):
  ALSA: usx2y: Avoid camelCase
  ALSA: usx2y: Fix spaces
  ALSA: usx2y: Coding style fixes
  ALSA: usx2y: Fix potential leaks of uninitialized memory
  ALSA: usx2y: Avoid self-killing
  ALSA: usx2y: Fix potential memory leaks
  ALSA: usxy2: Fix potential doubly allocations
  ALSA: usx2y: Fix shmem initialization
  ALSA: usx2y: Don't call free_pages_exact() with NULL address
  ALSA: usx2y: Cleanup probe and disconnect callbacks
  ALSA: usx2y: Nuke pcm_list

 sound/usb/usx2y/us122l.c          |  61 +--
 sound/usb/usx2y/us122l.h          |   2 +-
 sound/usb/usx2y/usX2Yhwdep.c      | 135 +++---
 sound/usb/usx2y/usX2Yhwdep.h      |   2 +-
 sound/usb/usx2y/usb_stream.c      |  82 ++--
 sound/usb/usx2y/usb_stream.h      |  23 +-
 sound/usb/usx2y/usbus428ctldefs.h | 104 ++---
 sound/usb/usx2y/usbusx2y.c        | 389 +++++++++--------
 sound/usb/usx2y/usbusx2y.h        |  65 ++-
 sound/usb/usx2y/usbusx2yaudio.c   | 684 ++++++++++++++++--------------
 sound/usb/usx2y/usx2yhwdeppcm.c   | 627 ++++++++++++++-------------
 sound/usb/usx2y/usx2yhwdeppcm.h   |   4 +-
 12 files changed, 1146 insertions(+), 1032 deletions(-)

-- 
2.26.2


             reply	other threads:[~2021-05-17 13:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 13:15 Takashi Iwai [this message]
2021-05-17 13:15 ` [PATCH 01/11] ALSA: usx2y: Avoid camelCase Takashi Iwai
2021-05-17 13:15 ` [PATCH 02/11] ALSA: usx2y: Fix spaces Takashi Iwai
2021-05-17 13:15 ` [PATCH 03/11] ALSA: usx2y: Coding style fixes Takashi Iwai
2021-05-17 13:15 ` [PATCH 04/11] ALSA: usx2y: Fix potential leaks of uninitialized memory Takashi Iwai
2021-05-17 13:15 ` [PATCH 05/11] ALSA: usx2y: Avoid self-killing Takashi Iwai
2021-05-17 13:15 ` [PATCH 06/11] ALSA: usx2y: Fix potential memory leaks Takashi Iwai
2021-05-17 13:15 ` [PATCH 07/11] ALSA: usxy2: Fix potential doubly allocations Takashi Iwai
2021-05-17 13:15 ` [PATCH 08/11] ALSA: usx2y: Fix shmem initialization Takashi Iwai
2021-05-17 13:15 ` [PATCH 09/11] ALSA: usx2y: Don't call free_pages_exact() with NULL address Takashi Iwai
2021-05-17 13:15 ` [PATCH 10/11] ALSA: usx2y: Cleanup probe and disconnect callbacks Takashi Iwai
2021-05-17 13:15 ` [PATCH 11/11] ALSA: usx2y: Nuke pcm_list Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517131545.27252-1-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).