From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FBEC433EF for ; Tue, 21 Sep 2021 11:13:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F3C460EC0 for ; Tue, 21 Sep 2021 11:13:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0F3C460EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 93378828; Tue, 21 Sep 2021 13:12:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 93378828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1632222793; bh=yyXhUn58lpN8Nc0YGD1K+xedQdRickg/qG3CoTgTXjU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=A3zGiG3iubc45a0ljPciIZBfEURXWOfoeBbB6t/c0+WIlAxBq7JpdtDknYFsJWbrs rr+WcwMiCc3kD4SiHbNjICdMYlz8+g7pzgW4MbI4L6nv7eVUX8yXCAPCRKqisNy25z f5Yefs3fLqQ+6wS/GXUt9gq9BjH2oMEaanc4VLsU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id ECC38F8025F; Tue, 21 Sep 2021 13:12:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E702FF80268; Tue, 21 Sep 2021 13:12:21 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 504BAF8016E for ; Tue, 21 Sep 2021 13:12:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 504BAF8016E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nBLlbnAS" Received: by mail.kernel.org (Postfix) with ESMTPSA id 06D6F60EC0; Tue, 21 Sep 2021 11:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632222732; bh=yyXhUn58lpN8Nc0YGD1K+xedQdRickg/qG3CoTgTXjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nBLlbnASKOEDfs+fPWH1yuBYrswejvtWMO/OWVRyY+UubhdPyN6vh0rYJJDYjxPeP UmE91P2HcZM3n1Lzw4W4YlgjuRN1v0osSiSpP1MBqDjnR/X1y96/b8J2V8CrsIRJen bJYYFDkI4rkv1yTkV4bwDk2nHOCLOBCclcAXOgH6GAuXyIQCZc1NDfCddZ2dEwDo8C bGzz5ejsuwpAeHYqowsr2UHJ4VxNFf6r/hcHXi6GwWUoy4eTFyxBHcGbe6Lc34/5fu lmnftTtUc51J2xA7qlp3uL33Lg8d32dFqmc+XsdlWr4cBrr94ogeiVubcI1PuPmLke PDgHXOzmAhIWQ== Date: Tue, 21 Sep 2021 12:11:28 +0100 From: Mark Brown To: Peter Rosin Subject: Re: [PATCH] ASoC: pcm512x: Mend accesses to the I2S_1 and I2S_2 registers Message-ID: <20210921111128.GA4203@sirena.org.uk> References: <2d221984-7a2e-7006-0f8a-ffb5f64ee885@axentia.se> <815cbba4-60d6-8d97-c483-146c2f7c3912@axentia.se> <8ee31fd2-3fbe-f5da-a030-c6b677c7f398@axentia.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <8ee31fd2-3fbe-f5da-a030-c6b677c7f398@axentia.se> X-Cookie: Quack! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , Liam Girdwood , "linux-kernel@vger.kernel.org" , Kirill Marinushkin , =?iso-8859-1?Q?P=E9ter?= Ujfalusi X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 21, 2021 at 08:37:28AM +0200, Peter Rosin wrote: > I expected it to just work to mark the register as readable and do > without the default value (i.e. the way it was before my patch). What > I don't understand is why regmap returns -EBUSY in that case. That > doesn't make sense to me. Perhaps that -EBUSY is propagated from the > I2C layer, but in that case, why is it then ok to do a write to > another register at the same spot in the code? So, why -EBUSY? Actually one thing that can trigger this now I think about it is attempting to access a volatile register when the device is in cache only mode for power management reasons - if the device is in cache only mode then you can't do a hardware read so volatile registers become inaccessible. --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFJvd8ACgkQJNaLcl1U h9CJKQf+OegzluneiRTJmiVh6LiL5bpcPOvlcoNyjQ9V7XuKD3L0HAt3Us2w4Uz1 zf61Wc7v3L50DjZ/bcEvPceanzWn2NjRwQCxHX9PTskwEAMGig5ydmm4rMBfWk6F hZFCefunu2I5armlczsLCuvPPmvIeE0fOk1/t4Ha92c4ifxyFWoB2uoe/bxLNxzH KhhHYssXI1D142G5khsfTMkzWNOIOIecjUuaQsTCO/AgdxO5K120c81ZzFJlVcKu GG2UcJSi3Qt4XAmfDqRgpO3r2E4DiI/8ZwPW/LZkZHkBwXvBYaOqM0ueYDTSF+Ny sam8UqO9TDsZC674q0fTaBS5mj+xoQ== =ztW7 -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--