From: Arnd Bergmann <arnd@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-tegra@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-mtd@lists.infradead.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-spi@vger.kernel.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
Lars-Peter Clausen <lars@metafoo.de>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-staging@lists.linux.dev,
Michal Simek <michal.simek@xilinx.com>,
Jon Hunter <jonathanh@nvidia.com>, Andy Gross <agross@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-serial@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-rpi-kernel@lists.infradead.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Hyun Kwon <hyun.kwon@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mmc@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Laxman Dewangan <ldewangan@nvidia.com>,
Baolin Wang <baolin.wang7@gmail.com>
Subject: [PATCH 06/11] dmaengine: sprd: stop referencing config->slave_id
Date: Mon, 15 Nov 2021 09:53:58 +0100 [thread overview]
Message-ID: <20211115085403.360194-7-arnd@kernel.org> (raw)
In-Reply-To: <20211115085403.360194-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
It appears that the code that reads the slave_id from the channel config
was copied incorrectly from other drivers. Nothing ever sets this field
on platforms that use this driver, so remove the reference.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/sprd-dma.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 4357d2395e6b..7f158ef5672d 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -795,9 +795,6 @@ static int sprd_dma_fill_desc(struct dma_chan *chan,
return dst_datawidth;
}
- if (slave_cfg->slave_id)
- schan->dev_id = slave_cfg->slave_id;
-
hw->cfg = SPRD_DMA_DONOT_WAIT_BDONE << SPRD_DMA_WAIT_BDONE_OFFSET;
/*
--
2.30.2
next prev parent reply other threads:[~2021-11-15 9:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 8:53 [PATCH 00/11] dmaengine: kill off dma_slave_config->slave_id Arnd Bergmann
2021-11-15 8:53 ` [PATCH 01/11] ASoC: dai_dma: remove slave_id field Arnd Bergmann
2021-11-15 10:14 ` Lars-Peter Clausen
2021-11-15 10:42 ` Arnd Bergmann
2021-11-15 11:53 ` Lars-Peter Clausen
2021-11-15 14:46 ` Dmitry Osipenko
2021-11-15 15:15 ` Arnd Bergmann
2021-11-15 8:53 ` [PATCH 02/11] spi: pic32: stop setting dma_config->slave_id Arnd Bergmann
2021-11-15 13:29 ` Mark Brown
2021-11-15 8:53 ` [PATCH 03/11] mmc: bcm2835: stop setting chan_config->slave_id Arnd Bergmann
2021-11-15 9:55 ` nicolas saenz julienne
2021-11-15 13:09 ` Ulf Hansson
2021-11-15 8:53 ` [PATCH 04/11] dmaengine: shdma: remove legacy slave_id parsing Arnd Bergmann
2021-11-15 9:09 ` Laurent Pinchart
2021-11-15 8:53 ` [PATCH 05/11] dmaengine: pxa/mmp: stop referencing config->slave_id Arnd Bergmann
2021-11-15 8:53 ` Arnd Bergmann [this message]
2021-11-16 2:34 ` [PATCH 06/11] dmaengine: sprd: " Baolin Wang
2021-11-15 8:53 ` [PATCH 07/11] dmaengine: qcom-adm: stop abusing slave_id config Arnd Bergmann
2021-11-19 12:42 ` kernel test robot
2021-11-25 7:57 ` kernel test robot
2021-11-25 8:25 ` Arnd Bergmann
2021-11-25 9:32 ` Vinod Koul
2021-11-15 8:54 ` [PATCH 08/11] dmaengine: xilinx_dpdma: stop using slave_id field Arnd Bergmann
2021-11-15 9:14 ` Laurent Pinchart
2021-11-15 10:21 ` Arnd Bergmann
2021-11-15 11:49 ` Laurent Pinchart
2021-11-15 12:38 ` Arnd Bergmann
2021-11-15 13:05 ` Laurent Pinchart
2021-11-15 13:39 ` Arnd Bergmann
2021-11-16 4:28 ` Vinod Koul
2021-11-15 8:54 ` [PATCH 09/11] dmaengine: tegra20-apb: stop checking config->slave_id Arnd Bergmann
2021-11-15 8:54 ` [PATCH 10/11] staging: ralink-gdma: stop using slave_id config Arnd Bergmann
2021-11-15 9:55 ` Sergio Paracuellos
2021-11-15 10:23 ` Arnd Bergmann
2021-11-15 8:54 ` [PATCH 11/11] dmaengine: remove slave_id config field Arnd Bergmann
2021-11-15 9:18 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115085403.360194-7-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=baolin.wang7@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hyun.kwon@xilinx.com \
--cc=jonathanh@nvidia.com \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mani@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nsaenz@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).