alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Liam Girdwood <lgirdwood@gmail.com>, Agneli <poczt@protonmail.ch>,
	Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v2 06/20] ASoC: tegra20-spdif: stop setting slave_id
Date: Fri, 26 Nov 2021 19:17:53 +0300	[thread overview]
Message-ID: <20211126161807.15776-7-digetx@gmail.com> (raw)
In-Reply-To: <20211126161807.15776-1-digetx@gmail.com>

From: Arnd Bergmann <arnd@arndb.de>

The DMA resource is never set up anywhere, and passing this as slave_id
has not been the proper procedure in a long time.

As a preparation for removing all slave_id references from the ALSA code,
remove this one.

According to Dmitry Osipenko, this driver has never been used and
the mechanism for configuring DMA would not work as it is implemented,
so this part will get rewritten when the driver gets put into use
again in the future.

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/tegra/tegra20_spdif.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/tegra/tegra20_spdif.c b/sound/soc/tegra/tegra20_spdif.c
index 6f0570cde964..e45e371edc42 100644
--- a/sound/soc/tegra/tegra20_spdif.c
+++ b/sound/soc/tegra/tegra20_spdif.c
@@ -298,7 +298,6 @@ static int tegra20_spdif_platform_probe(struct platform_device *pdev)
 	spdif->playback_dma_data.addr = mem->start + TEGRA20_SPDIF_DATA_OUT;
 	spdif->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
 	spdif->playback_dma_data.maxburst = 4;
-	spdif->playback_dma_data.slave_id = dmareq->start;
 
 	pm_runtime_enable(&pdev->dev);
 
-- 
2.33.1


  parent reply	other threads:[~2021-11-26 16:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 16:17 [PATCH v2 00/20] Support HDMI audio on NVIDIA Tegra20 Dmitry Osipenko
2021-11-26 16:17 ` [PATCH v2 01/20] ASoC: dt-bindings: Add binding for Tegra20 S/PDIF Dmitry Osipenko
2021-12-01 23:48   ` Rob Herring
2021-11-26 16:17 ` [PATCH v2 02/20] ASoC: dt-bindings: tegra20-i2s: Convert to schema Dmitry Osipenko
2021-12-01 23:50   ` Rob Herring
2021-11-26 16:17 ` [PATCH v2 03/20] ASoC: dt-bindings: tegra20-i2s: Document new nvidia, fixed-parent-rate property Dmitry Osipenko
2021-12-01 23:50   ` [PATCH v2 03/20] ASoC: dt-bindings: tegra20-i2s: Document new nvidia,fixed-parent-rate property Rob Herring
2021-11-26 16:17 ` [PATCH v2 04/20] dt-bindings: host1x: Document optional HDMI sound-dai-cells Dmitry Osipenko
2021-12-01 23:50   ` Rob Herring
2021-11-26 16:17 ` [PATCH v2 05/20] ASoC: tegra20: spdif: Set FIFO trigger level Dmitry Osipenko
2021-11-26 16:17 ` Dmitry Osipenko [this message]
2021-11-26 16:17 ` [PATCH v2 07/20] ASoC: tegra20: spdif: Support device-tree Dmitry Osipenko
2021-11-26 16:17 ` [PATCH v2 08/20] ASoC: tegra20: spdif: Improve driver's code Dmitry Osipenko
2021-11-26 16:17 ` [PATCH v2 09/20] ASoC: tegra20: spdif: Use more resource-managed helpers Dmitry Osipenko
2021-11-26 16:17 ` [PATCH v2 10/20] ASoC: tegra20: spdif: Reset hardware Dmitry Osipenko
2021-11-26 16:17 ` [PATCH v2 11/20] ASoC: tegra20: spdif: Support system suspend Dmitry Osipenko
2021-11-26 16:17 ` [PATCH v2 12/20] ASoC: tegra20: spdif: Filter out unsupported rates Dmitry Osipenko
2021-11-26 16:18 ` [PATCH v2 13/20] ASoC: tegra20: i2s: " Dmitry Osipenko
2021-11-26 16:18 ` [PATCH v2 14/20] drm/tegra: hdmi: Unwind tegra_hdmi_init() errors Dmitry Osipenko
2021-11-26 16:18 ` [PATCH v2 15/20] drm/tegra: hdmi: Register audio CODEC on Tegra20 Dmitry Osipenko
2021-11-26 16:18 ` [PATCH v2 16/20] ARM: tegra_defconfig: Enable S/PDIF driver Dmitry Osipenko
2021-11-26 16:18 ` [PATCH v2 17/20] ARM: tegra: Add S/PDIF node to Tegra20 device-tree Dmitry Osipenko
2021-11-26 16:18 ` [PATCH v2 18/20] ARM: tegra: Add HDMI audio graph " Dmitry Osipenko
2021-11-26 16:18 ` [PATCH v2 19/20] ARM: tegra: acer-a500: Enable S/PDIF and HDMI audio Dmitry Osipenko
2021-11-26 16:18 ` [PATCH v2 20/20] ARM: tegra: paz00: " Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211126161807.15776-7-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=poczt@protonmail.ch \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).