From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: broonie@kernel.org
Cc: tiwai@suse.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
johan+linaro@kernel.org, steev@kali.org,
dmitry.baryshkov@linaro.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 1/4] ASoC: qcom: q6apm-lpass-dai: close graphs before opening a new one
Date: Thu, 23 Mar 2023 16:44:00 +0000 [thread overview]
Message-ID: <20230323164403.6654-2-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20230323164403.6654-1-srinivas.kandagatla@linaro.org>
On multiple prepare calls, its possible that the playback graphs are
not unloaded from the DSP, which can have some wierd side-effects,
one of them is that the data not consumed without any errors.
Fixes: c2ac3aec474d("ASoC: qcom: q6apm-lpass-dai: unprepare stream if its already prepared")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
index 23d23bc6fbaa..420e8aa11f42 100644
--- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
+++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
@@ -130,6 +130,9 @@ static int q6apm_lpass_dai_prepare(struct snd_pcm_substream *substream, struct s
if (dai_data->is_port_started[dai->id]) {
q6apm_graph_stop(dai_data->graph[dai->id]);
dai_data->is_port_started[dai->id] = false;
+
+ if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+ q6apm_graph_close(dai_data->graph[dai->id]);
}
/**
--
2.21.0
next prev parent reply other threads:[~2023-03-23 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:43 [PATCH 0/4] ASoC: qcom: fixes for Click/Pop Noise Srinivas Kandagatla
2023-03-23 16:44 ` Srinivas Kandagatla [this message]
2023-03-23 16:44 ` [PATCH 2/4] ASoC: qcom: sdw: do not restart soundwire ports for every prepare Srinivas Kandagatla
2023-03-23 16:44 ` [PATCH 3/4] ASoC: codecs: wsa883x: mute/unmute PA in correct sequence Srinivas Kandagatla
2023-03-23 17:07 ` Mark Brown
2023-03-23 18:11 ` Pierre-Louis Bossart
2023-03-24 0:14 ` Mark Brown
2023-03-24 6:43 ` Srinivas Kandagatla
2023-03-24 6:44 ` Srinivas Kandagatla
2023-10-25 7:57 ` Johan Hovold
2023-10-25 12:36 ` Mark Brown
2023-10-25 12:43 ` Johan Hovold
2023-10-26 13:05 ` Mark Brown
2023-10-26 13:55 ` Johan Hovold
2023-10-27 10:51 ` Srinivas Kandagatla
2023-03-23 16:44 ` [PATCH 4/4] ASoC: codecs: wsa881x: " Srinivas Kandagatla
2023-04-06 15:03 ` (subset) [PATCH 0/4] ASoC: qcom: fixes for Click/Pop Noise Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323164403.6654-2-srinivas.kandagatla@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steev@kali.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).