From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>,
agross@kernel.org, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, bjorn.andersson@linaro.org,
broonie@kernel.org, devicetree@vger.kernel.org,
lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, perex@perex.cz,
plai@codeaurora.org, robh+dt@kernel.org, rohitkr@codeaurora.org,
srinivas.kandagatla@linaro.org, tiwai@suse.com
Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH v3 4/5] ASoC: qcom: Add support for audio over DP
Date: Thu, 3 Sep 2020 14:53:49 +0530 [thread overview]
Message-ID: <25a8ca32-47f9-fb04-5f76-cc9e27f4e412@codeaurora.org> (raw)
In-Reply-To: <159894552988.334488.8290895362888910651@swboyd.mtv.corp.google.com>
Thanks Stephen, for your time for review!!!
On 9/1/2020 1:02 PM, Stephen Boyd wrote:
> Quoting Srinivasa Rao Mandadapu (2020-08-30 23:39:23)
>> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
>> index 167bf2c..cea7ae7 100644
>> --- a/sound/soc/qcom/lpass-sc7180.c
>> +++ b/sound/soc/qcom/lpass-sc7180.c
>> @@ -190,15 +232,92 @@ static struct lpass_variant sc7180_data = {
>> "mi2s-bit-clk0",
>> "mi2s-bit-clk1",
>> },
>> + .id = I2S_INTERFACE,
>> .init = sc7180_lpass_init,
>> .exit = sc7180_lpass_exit,
>> .alloc_dma_channel = sc7180_lpass_alloc_dma_channel,
>> .free_dma_channel = sc7180_lpass_free_dma_channel,
>> };
>>
>> +static struct lpass_variant sc7180_hdmi_data = {
> Can this be const?
Yes this can be constant. will change in next patch.
>
>> + .hdmi_tx_ctl_addr = 0x1000,
>> + .hdmi_legacy_addr = 0x1008,
>> + .hdmi_vbit_addr = 0x610c0,
>> + .hdmi_ch_lsb_addr = 0x61048,
>> + .hdmi_ch_msb_addr = 0x6104c,
>> + .ch_stride = 0x8,
>> + .hdmi_parity_addr = 0x61034,
>> + .hdmi_dmactl_addr = 0x61038,
>> + .hdmi_dma_stride = 0x4,
>> + .hdmi_DP_addr = 0x610c8,
>> + .hdmi_sstream_addr = 0x6101c,
>> + .irq_reg_base = 0x63000,
>> + .irq_ports = 1,
>> + .rdma_reg_base = 0x64000,
>> + .rdma_reg_stride = 0x1000,
>> + .rdma_channels = 4,
>> +
>> + .rdma_dyncclk = REG_FIELD_ID(0x64000, 14, 14, 4, 0x1000),
>> + .rdma_bursten = REG_FIELD_ID(0x64000, 13, 13, 4, 0x1000),
>> + .rdma_burst8 = REG_FIELD_ID(0x64000, 15, 15, 4, 0x1000),
>> + .rdma_burst16 = REG_FIELD_ID(0x64000, 16, 16, 4, 0x1000),
>> + .rdma_dynburst = REG_FIELD_ID(0x64000, 18, 18, 4, 0x1000),
>> + .rdma_wpscnt = REG_FIELD_ID(0x64000, 10, 12, 4, 0x1000),
>> + .rdma_fifowm = REG_FIELD_ID(0x64000, 1, 5, 4, 0x1000),
>> + .rdma_enable = REG_FIELD_ID(0x64000, 0, 0, 4, 0x1000),
>> +
>> + .sstream_en = REG_FIELD(0x6101c, 0, 0),
>> + .dma_sel = REG_FIELD(0x6101c, 1, 2),
>> + .auto_bbit_en = REG_FIELD(0x6101c, 3, 3),
>> + .layout = REG_FIELD(0x6101c, 4, 4),
>> + .layout_sp = REG_FIELD(0x6101c, 5, 8),
>> + .set_sp_on_en = REG_FIELD(0x6101c, 10, 10),
>> + .dp_audio = REG_FIELD(0x6101c, 11, 11),
>> + .dp_staffing_en = REG_FIELD(0x6101c, 12, 12),
>> + .dp_sp_b_hw_en = REG_FIELD(0x6101c, 13, 13),
>> +
>> + .mute = REG_FIELD(0x610c8, 0, 0),
>> + .as_sdp_cc = REG_FIELD(0x610c8, 1, 3),
>> + .as_sdp_ct = REG_FIELD(0x610c8, 4, 7),
>> + .aif_db4 = REG_FIELD(0x610c8, 8, 15),
>> + .frequency = REG_FIELD(0x610c8, 16, 21),
>> + .mst_index = REG_FIELD(0x610c8, 28, 29),
>> + .dptx_index = REG_FIELD(0x610c8, 30, 31),
>> +
>> + .soft_reset = REG_FIELD(0x1000, 31, 31),
>> + .force_reset = REG_FIELD(0x1000, 30, 30),
>> +
>> + .use_hw_chs = REG_FIELD(0x61038, 0, 0),
>> + .use_hw_usr = REG_FIELD(0x61038, 1, 1),
>> + .hw_chs_sel = REG_FIELD(0x61038, 2, 4),
>> + .hw_usr_sel = REG_FIELD(0x61038, 5, 6),
>> +
>> + .replace_vbit = REG_FIELD(0x610c0, 0, 0),
>> + .vbit_stream = REG_FIELD(0x610c0, 1, 1),
>> +
>> + .legacy_en = REG_FIELD(0x1008, 0, 0),
>> + .calc_en = REG_FIELD(0x61034, 0, 0),
>> + .lsb_bits = REG_FIELD(0x61048, 0, 31),
>> + .msb_bits = REG_FIELD(0x6104c, 0, 31),
>> +
>> + .clk_name = (const char*[]) {
>> + "pcnoc-sway-clk",
>> + "audio-core",
>> + "pcnoc-mport-clk",
>> + },
>> + .num_clks = 3,
>> + .id = HDMI_INTERFACE,
>> + .dai_driver = sc7180_lpass_cpu_hdmi_dai_driver,
>> + .num_dai = ARRAY_SIZE(sc7180_lpass_cpu_hdmi_dai_driver),
>> + .init = sc7180_lpass_init,
>> + .exit = sc7180_lpass_exit,
>> + .alloc_dma_channel = sc7180_lpass_alloc_hdmi_dma_channel,
>> + .free_dma_channel = sc7180_lpass_free_hdmi_dma_channel,
>> +
>> +};
> Add a newline here?
okay
>
>> static const struct of_device_id sc7180_lpass_cpu_device_id[] = {
>> {.compatible = "qcom,sc7180-lpass-cpu", .data = &sc7180_data},
>> - {}
>> + {.compatible = "qcom,sc7180-lpass-hdmi", .data = &sc7180_hdmi_data}
> This most likely needs to keep the sentinel around so that a match can
> be made or stop if nothing is found.
okay..
>
>> };
>>
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-09-03 9:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 6:39 [PATCH v3 0/5] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port Srinivasa Rao Mandadapu
2020-08-31 6:39 ` [PATCH v3 1/5] ASoC: Add sc7180-lpass binding header hdmi define Srinivasa Rao Mandadapu
2020-08-31 6:39 ` [PATCH v3 2/5] ASoC: dt-bindings: Add dt binding for lpass hdmi Srinivasa Rao Mandadapu
2020-09-04 10:41 ` Srinivas Kandagatla
2020-09-04 11:02 ` Srinivasa Rao Mandadapu
2020-08-31 6:39 ` [PATCH v3 3/5] ASoC: qcom: Add support for lpass hdmi driver Srinivasa Rao Mandadapu
2020-09-01 7:36 ` Stephen Boyd
2020-09-03 9:29 ` Srinivasa Rao Mandadapu
2020-09-04 10:41 ` Srinivas Kandagatla
2020-09-04 11:21 ` Srinivasa Rao Mandadapu
[not found] ` <0101017458d94c82-96bbcff0-018e-4f5d-8273-7869c3599d32-000000@us-west-2.amazonses.com>
2020-09-04 11:24 ` Srinivas Kandagatla
2020-09-08 17:42 ` Srinivasa Rao Mandadapu
2020-08-31 6:39 ` [PATCH v3 4/5] ASoC: qcom: Add support for audio over DP Srinivasa Rao Mandadapu
2020-09-01 7:32 ` Stephen Boyd
2020-09-03 9:23 ` Srinivasa Rao Mandadapu [this message]
2020-08-31 6:39 ` [PATCH v3 5/5] ASoC: qcom: Optimise lpass variant structure Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25a8ca32-47f9-fb04-5f76-cc9e27f4e412@codeaurora.org \
--to=srivasam@codeaurora.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).