From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F00DC433E0 for ; Mon, 10 Aug 2020 07:18:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22E902073A for ; Mon, 10 Aug 2020 07:18:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="mGLbXD/J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22E902073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9C98315F9; Mon, 10 Aug 2020 09:17:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9C98315F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597043878; bh=BOzVhhKXPBlqTHLysOI7omL7BH+XJiwh7xMXwSK7hTg=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mGLbXD/JRFFsZjWExm6oHkUqtFujzaTwd8TfswS3Jcb6td+vBm4KTe4Aow69nqEep IPU5q0cS5LeXkRwGJ4N01O1dD0hBMCZMGVOjAxEv2KYQUD0gVQ9cVEL6Zs/ZRwAKaC bGs8e6m3apqpwU+C6eVwGD8w9DrFFll4GJYCLTew= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2B64FF801DB; Mon, 10 Aug 2020 09:17:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CCB54F800BC; Mon, 10 Aug 2020 09:17:06 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0E2B8F800BC for ; Mon, 10 Aug 2020 09:16:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0E2B8F800BC IronPort-SDR: hrTJcmXDjNAJot3opjAMb0XjRg+4fBeWOK3v/t3ahwT0nkjqCeVxulH07NjCGJ5Ew7kFep2SIr OZR+fjLKKgHw== X-IronPort-AV: E=McAfee;i="6000,8403,9708"; a="141095720" X-IronPort-AV: E=Sophos;i="5.75,456,1589266800"; d="scan'208";a="141095720" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 00:16:53 -0700 IronPort-SDR: FAGNOisr2ije6Sy9AP+9TEgxwVQg9Y68dkR7JscLU+eyZDraKng2Ea6mtdY0vGWGPOLzxXfUgX p9eVSNruVLMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,456,1589266800"; d="scan'208";a="275934992" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.249.154.188]) ([10.249.154.188]) by fmsmga007.fm.intel.com with ESMTP; 10 Aug 2020 00:16:49 -0700 Subject: Re: [PATCH 07/13] ASoC: Intel: catpt: Event tracing To: Mark Brown References: <20200807110649.17114-1-cezary.rojewski@intel.com> <20200807110649.17114-8-cezary.rojewski@intel.com> <20200807150908.GN5435@sirena.org.uk> From: Cezary Rojewski Message-ID: <2e964389-9917-91a4-5f41-7031e54f83a5@intel.com> Date: Mon, 10 Aug 2020 09:16:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200807150908.GN5435@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, andriy.shevchenko@intel.com, filip.kaczmarski@intel.com, harshapriya.n@intel.com, marcin.barlik@intel.com, zwisler@google.com, lgirdwood@gmail.com, tiwai@suse.com, filip.proborszcz@intel.com, michal.wasko@intel.com, cujomalainey@chromium.org, ppapierkowski@habana.ai, vamshi.krishna.gopal@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-08-07 5:09 PM, Mark Brown wrote: > On Fri, Aug 07, 2020 at 01:06:43PM +0200, Cezary Rojewski wrote: >> Define tracing macros for easy catpt debug. These are divided into >> memory, registry and ipc event categories. >> >> Signed-off-by: Cezary Rojewski >> --- >> sound/soc/intel/catpt/trace.h | 169 ++++++++++++++++++++++++++++++++++ > > Usually events go into include/trace/events/ > Thought TRACE_INCLUDE_FILE/ _PATH are designed specifically to remove the need for trace.h to go into mentioned folder. Based my decision on fact that sound/hda and sound/core have their traces defined locally. What's the preferred way? >> +/* SPDX-License-Identifier: GPL-2.0 > > This needs to be a separate comment to match the spec. > Ack.