From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, broonie@kernel.org,
srinivas.kandagatla@linaro.org,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [PATCH v2 2/2] soundwire: sysfs: add slave status and device number before probe
Date: Mon, 21 Sep 2020 09:34:06 -0500 [thread overview]
Message-ID: <2ef2e1e8-d7cc-a08f-4176-240750d640a5@linux.intel.com> (raw)
In-Reply-To: <20200919111911.GW2968@vkoul-mobl>
On 9/19/20 6:19 AM, Vinod Koul wrote:
> On 18-09-20, 09:21, Pierre-Louis Bossart wrote:
>>
>>
>>
>>>> * Base file is device
>>>> * |---- modalias
>>>> + * |---- dev-status
>>>> + * |---- status
>>>> + * |---- device_number
>>>
>>> Any reason why we want this under dev-status.
>>>
>>> Both the status and device_number belong to the device, so we can
>>> put them under device and use device properties
>>
>> We already use directories for device-level and port-level properties, I
>> just thought it be cleaner to continue this model. We might also expand the
>> information later on, e.g. provide interrupt status.
>
> Right now we have directories for N ports (needs a dir due to nature of
> N ports) and 'properties' derived from Disco/firmware.
> So Nport and properties makes sense. But for generic device level stuff
> like device number, status and future interrupt or anything should be at
> device level.
>
>> I don't mind if we remove the directory and move everything up one level,
>> but it wouldn't be consistent with the previous work.
>
> Just because we had directory for a reason, adding a directory to
> conform to that does make it better. IMO device files should be at
> device directory
We have a "dev-properties" directory, which is added after the driver
probe, and describes MIPI DisCo values at the device level.
Either we remove this dev-properties and move it to the device level -
to be consistent with your recommendation - or we keep separate
directories, one which is populated on device registration and the other
on driver probe.
next prev parent reply other threads:[~2020-09-21 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 16:00 [PATCH v2 0/2] soundwire: sysfs: expose device number and status Pierre-Louis Bossart
2020-09-17 16:00 ` [PATCH v2 1/2] soundwire: bus: add enumerated Slave device to device list Pierre-Louis Bossart
2020-09-18 12:05 ` Vinod Koul
2020-09-18 13:54 ` Pierre-Louis Bossart
2020-09-19 11:13 ` Vinod Koul
2020-09-17 16:00 ` [PATCH v2 2/2] soundwire: sysfs: add slave status and device number before probe Pierre-Louis Bossart
2020-09-17 16:36 ` Greg KH
2020-09-18 12:16 ` Vinod Koul
2020-09-18 14:21 ` Pierre-Louis Bossart
2020-09-19 11:19 ` Vinod Koul
2020-09-21 14:34 ` Pierre-Louis Bossart [this message]
2020-09-23 10:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ef2e1e8-d7cc-a08f-4176-240750d640a5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=rander.wang@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).