From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
alsa-devel@alsa-project.org, tiwai@suse.de, vkoul@kernel.org,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [PATCH 2/2] soundwire: sysfs: add slave status and device number before probe
Date: Thu, 17 Sep 2020 07:54:50 -0500 [thread overview]
Message-ID: <2fc52eda-5c4a-e970-8a74-43c2037f9e0f@linux.intel.com> (raw)
In-Reply-To: <20200917091938.GB52206@kroah.com>
Thanks for the review Greg,
>> +int sdw_slave_status_sysfs_init(struct sdw_slave *slave)
>> +{
>> + return device_add_group(&slave->dev, &sdw_slave_status_attr_group);
>
> DOesn't this race with userspace? Why not make this part of the default
> set of device attributes and have the driver core create them
> automatically?
What did you mean by 'default set of device attributes', would you mind
providing a pointer to an example so that I can look into this?
What we have in this patch is added by the SoundWire core but you're
probably thinking of something else. thanks for enlightening the rest of
us:-)
next prev parent reply other threads:[~2020-09-17 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 20:15 [PATCH 0/2] soundwire: sysfs: expose device number and status Pierre-Louis Bossart
2020-09-16 20:15 ` [PATCH 1/2] soundwire: bus: add enumerated Slave device to device list Pierre-Louis Bossart
2020-09-16 20:15 ` [PATCH 2/2] soundwire: sysfs: add slave status and device number before probe Pierre-Louis Bossart
2020-09-17 9:19 ` Greg KH
2020-09-17 12:54 ` Pierre-Louis Bossart [this message]
2020-09-17 13:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fc52eda-5c4a-e970-8a74-43c2037f9e0f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).