From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Perry Yuan <perry979106@gmail.com>,
Perry Yuan <Perry.Yuan@dell.com>,
oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com,
hdegoede@redhat.com, mgross@linux.intel.com
Cc: alsa-devel@alsa-project.org, Mario.Limonciello@dell.com,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
platform-driver-x86@vger.kernel.org, broonie@kernel.org
Subject: Re: [PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell hardware privacy
Date: Tue, 16 Feb 2021 08:56:52 -0600 [thread overview]
Message-ID: <31982e8d-3b0d-7187-8798-900f95d876ee@linux.intel.com> (raw)
In-Reply-To: <79277bf2-3c9e-8b66-47a9-b926a2576f7f@gmail.com>
>>> +static const struct acpi_device_id privacy_acpi_device_ids[] = {
>>> + {"PNP0C09", 0},
>>> + { },
>>> +};
>>> +MODULE_DEVICE_TABLE(acpi, privacy_acpi_device_ids);
>>> +
>>> +static struct platform_driver dell_privacy_platform_drv = {
>>> + .driver = {
>>> + .name = PRIVACY_PLATFORM_NAME,
>>> + .acpi_match_table = ACPI_PTR(privacy_acpi_device_ids),
>>> + },
>>
>> no .probe?
> Originally i added the probe here, but it cause the driver .probe
> called twice. after i use platform_driver_probe to register the driver
> loading process, the duplicated probe issue resolved.
>
> I
>>
>>> + .remove = dell_privacy_acpi_remove,
>>> +};
>>> +
>>> +int __init dell_privacy_acpi_init(void)
>>> +{
>>> + int err;
>>> + struct platform_device *pdev;
>>> + int privacy_capable = wmi_has_guid(DELL_PRIVACY_GUID);
>>> +
>>> + if (!wmi_has_guid(DELL_PRIVACY_GUID))
>>> + return -ENODEV;
>>> +
>>> + privacy_acpi = kzalloc(sizeof(*privacy_acpi), GFP_KERNEL);
>>> + if (!privacy_acpi)
>>> + return -ENOMEM;
>>> +
>>> + pdev = platform_device_register_simple(
>>> + PRIVACY_PLATFORM_NAME, PLATFORM_DEVID_NONE, NULL, 0);
>>> + if (IS_ERR(pdev)) {
>>> + err = PTR_ERR(pdev);
>>> + goto pdev_err;
>>> + }
>>> + err = platform_driver_probe(&dell_privacy_platform_drv,
>>> + dell_privacy_acpi_probe);
>>> + if (err)
>>> + goto pdrv_err;
>>
>> why is the probe done here? Put differently, what prevents you from
>> using a 'normal' platform driver, and do the leds_setup in the .probe()?
> At first ,I used the normal platform driver framework, however tt cause
> the driver .probe called twice. after i use platform_driver_probe to
> register the driver loading process, the duplicated probe issue resolved.
This sounds very odd...
this looks like a conflict with the ACPI subsystem finding a device and
probing the driver that's associated with the PNP0C09 HID, and then this
module __init creating a device manually which leads to a second probe
Neither the platform_device_register_simple() nor
platform_driver_probe() seem necessary?
next prev parent reply other threads:[~2021-02-16 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 17:17 [PATCH v3 1/3] platform/x86: dell-privacy: Add support for Dell hardware privacy Perry Yuan
2021-01-12 17:39 ` Randy Dunlap
2021-01-16 15:10 ` Perry Yuan
2021-02-14 7:23 ` Perry Yuan
2021-01-12 19:00 ` Pierre-Louis Bossart
2021-02-16 6:48 ` Perry Yuan
2021-02-16 14:56 ` Pierre-Louis Bossart [this message]
2021-02-17 12:47 ` Perry Yuan
2021-02-17 14:23 ` Pierre-Louis Bossart
2021-03-05 2:56 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31982e8d-3b0d-7187-8798-900f95d876ee@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=perry979106@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).