From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BD4C433E0 for ; Wed, 27 Jan 2021 15:23:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFE312079A for ; Wed, 27 Jan 2021 15:23:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFE312079A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D382F171C; Wed, 27 Jan 2021 16:22:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D382F171C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1611760994; bh=rRQCtxLS3p35RloIwxmToiL5jdTgvypnDqnrAAyzef0=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=R/dUDlKEVsGyqQ8VgFxUOTTkw6zTjhvCkJ4ZsFKPKEbzPhkYNo/af7R0/HJ0cEuqB KrlRWvA5DhHxQmq9Dn4MC2zHcK3C1LSVmHkDbItT8QqSTYpYmvvfiZCbljT+cpJONY r6bXvsurCSHSQJXsyklKHqixdqW/9Sw8AU2XhP58= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 55240F80218; Wed, 27 Jan 2021 16:22:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6C2BAF80259; Wed, 27 Jan 2021 16:22:22 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DCE06F800F0 for ; Wed, 27 Jan 2021 16:22:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DCE06F800F0 IronPort-SDR: fnotB/hgWoe+rTkeL06+/8mPMAVXT6Fuo/5Qns91c7O2HeIdffVgB6ojsBQ3r4NvQYCbtWf0fJ v5cyXY170dCQ== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="180227835" X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="180227835" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 07:22:12 -0800 IronPort-SDR: kgjPlbuVitWjt9XnqWcoyhwRgj12MpPB+Ksc51ZdAnzxZ7zwx5k7yY+PpHem4mNyYbNf/+K+yE z+Jcnj91Pi6A== X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="430131658" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.213.1.157]) ([10.213.1.157]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 07:22:08 -0800 Subject: Re: [PATCH] ASoC: Intel: Skylake: Compile when any configuration is selected To: Kai-Heng Feng References: <20210125115441.10383-1-cezary.rojewski@intel.com> From: Cezary Rojewski Message-ID: <324dc8a5-c4d3-6ebf-c8e9-6321d6c93dab@intel.com> Date: Wed, 27 Jan 2021 16:22:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: Pierre-Louis Bossart , "moderated list:SOUND" , Liam Girdwood , Takashi Iwai , Hans de Goede , Mark Brown , =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2021-01-27 9:03 AM, Kai-Heng Feng wrote: > On Mon, Jan 25, 2021 at 7:55 PM Cezary Rojewski > wrote: >> >> Skylake is dependent on SND_SOC_INTEL_SKYLAKE (aka "all SST platforms") >> whereas selecting specific configuration such as KBL-only will not >> cause driver code to compile. Switch to SND_SOC_INTEL_SKYLAKE_COMMON >> dependency so selecting any configuration causes the driver to be built. >> >> Reported-by: Kai-Heng Feng >> Suggested-by: Amadeusz Sławiński >> Fixes: 35bc99aaa1a3 ("ASoC: Intel: Skylake: Add more platform granularity") >> Signed-off-by: Cezary Rojewski > > Still not working: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1902457/comments/66 > Hello, Thanks for your reply Kai-Heng. I believe you're relating to completely different issue than the one this very patch is targeting. From the logs you've provided one can see that snd_soc_skl did attempt to probe() so the code compiled just fine. Again, compilation issue is the one I've addressed here. While we're here, I'd appreciate kconfig being provided along dmesg file. Logs alone do not show the entire picture, unfortunately. In regard to missing sound, (looks like we're talking about HDA dsp + DMIC configuration) kconfig mentioned above will be required. Pretty sure HDAudio support for skylake-driver is not enabled on your machine and thus driver exists probe() early without registering any sound card. Regards, Czarek