From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Saalim Quadri <danascape@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
daniel.baluta@nxp.com, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v3] ASoC: dt-bindings: alc5632: Convert to dtschema
Date: Sun, 26 Mar 2023 16:46:56 +0200 [thread overview]
Message-ID: <324e710d-de76-23dc-de4b-d34e32e63aca@linaro.org> (raw)
In-Reply-To: <20230326131039.19190-1-danascape@gmail.com>
On 26/03/2023 15:10, Saalim Quadri wrote:
> Convert the ALC5632 audio codec bindings to DT schema.
You got comment about threading. Do not ignore it.
>
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
> ---
Where is the changelog? What happened here?
> .../devicetree/bindings/sound/alc5632.txt | 43 -------------
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + alc5632: codec@1a {
No improvements here.
> + compatible = "realtek,alc5632";
> + reg = <0x1a>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> + };
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-26 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 13:05 [PATCH] ASoC: dt-bindings: alc5632: Convert to dtschema Saalim Quadri
2023-03-23 15:15 ` Krzysztof Kozlowski
2023-03-23 17:11 ` Saalim Quadri
2023-03-23 19:08 ` Krzysztof Kozlowski
2023-03-23 19:17 ` Mark Brown
2023-03-23 19:37 ` [PATCH v2] " Saalim Quadri
2023-03-24 0:03 ` Mark Brown
2023-03-24 8:43 ` Krzysztof Kozlowski
2023-03-24 8:45 ` Krzysztof Kozlowski
2023-03-24 8:45 ` [PATCH] " Krzysztof Kozlowski
2023-03-25 16:36 ` [PATCH v2] " Saalim Quadri
2023-03-26 13:10 ` [PATCH v3] " Saalim Quadri
2023-03-26 14:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=324e710d-de76-23dc-de4b-d34e32e63aca@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=danascape@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).