From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
robh+dt@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route
Date: Thu, 29 Oct 2020 10:52:23 -0500 [thread overview]
Message-ID: <3300f31e-28d1-becf-41e7-814b38082dcb@linux.intel.com> (raw)
In-Reply-To: <20201029110829.16425-4-srinivas.kandagatla@linaro.org>
> +static int wsa_macro_enable_mix_path(struct snd_soc_dapm_widget *w,
> + struct snd_kcontrol *kcontrol, int event)
> +{
> + struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> + u16 gain_reg;
> + int offset_val = 0;
> + int val = 0;
> +
> + switch (w->reg) {
> + case CDC_WSA_RX0_RX_PATH_MIX_CTL:
> + gain_reg = CDC_WSA_RX0_RX_VOL_MIX_CTL;
> + break;
> + case CDC_WSA_RX1_RX_PATH_MIX_CTL:
> + gain_reg = CDC_WSA_RX1_RX_VOL_MIX_CTL;
> + break;
> + default:
> + return 0;
> + }
> +
> + switch (event) {
> + case SND_SOC_DAPM_POST_PMU:
> + val = snd_soc_component_read(component, gain_reg);
> + val += offset_val;
> + snd_soc_component_write(component, gain_reg, val);
missed from v1: offset_val is zero so the sequence is reading and
writing the same thing. Is this intentional or useful?
> + break;
> + case SND_SOC_DAPM_POST_PMD:
> + snd_soc_component_update_bits(component, w->reg,
> + CDC_WSA_RX_PATH_MIX_CLK_EN_MASK,
> + CDC_WSA_RX_PATH_MIX_CLK_DISABLE);
> + break;
> + }
> +
> + return 0;
> +}
> +
[...]
> +static bool wsa_macro_adie_lb(struct snd_soc_component *component,
> + int interp_idx)
> +{
> + u16 int_mux_cfg0 = 0, int_mux_cfg1 = 0;
these inits are ignored
> + u8 int_mux_cfg0_val = 0, int_mux_cfg1_val = 0;
these as well
> + u8 int_n_inp0 = 0, int_n_inp1 = 0, int_n_inp2 = 0;
and these are also ignored.
> + int_mux_cfg0 = CDC_WSA_RX_INP_MUX_RX_INT0_CFG0 + interp_idx * 8;
> + int_mux_cfg1 = int_mux_cfg0 + 4;
> + int_mux_cfg0_val = snd_soc_component_read(component, int_mux_cfg0);
> + int_mux_cfg1_val = snd_soc_component_read(component, int_mux_cfg1);
> +
> + int_n_inp0 = int_mux_cfg0_val & 0x0F;
> + if (int_n_inp0 == INTn_1_INP_SEL_DEC0 ||
> + int_n_inp0 == INTn_1_INP_SEL_DEC1)
> + return true;
> +
> + int_n_inp1 = int_mux_cfg0_val >> 4;
> + if (int_n_inp1 == INTn_1_INP_SEL_DEC0 ||
> + int_n_inp1 == INTn_1_INP_SEL_DEC1)
> + return true;
> +
> + int_n_inp2 = int_mux_cfg1_val >> 4;
> + if (int_n_inp2 == INTn_1_INP_SEL_DEC0 ||
> + int_n_inp2 == INTn_1_INP_SEL_DEC1)
> + return true;
> +
> + return false;
> +}
next prev parent reply other threads:[~2020-10-29 16:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 11:08 [PATCH v2 0/6] ASoC: codecs: add support for LPASS Codec macros Srinivas Kandagatla
2020-10-29 11:08 ` [PATCH v2 1/6] ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec Srinivas Kandagatla
2020-11-04 21:20 ` Rob Herring
2020-10-29 11:08 ` [PATCH v2 2/6] ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro Srinivas Kandagatla
2020-10-29 15:47 ` Pierre-Louis Bossart
2020-11-03 12:31 ` Srinivas Kandagatla
2020-10-29 11:08 ` [PATCH v2 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route Srinivas Kandagatla
2020-10-29 15:52 ` Pierre-Louis Bossart [this message]
2020-11-03 12:31 ` Srinivas Kandagatla
2020-11-03 15:51 ` Pierre-Louis Bossart
2020-10-29 11:08 ` [PATCH v2 4/6] ASoC: qcom: dt-bindings: add bindings for lpass va macro codec Srinivas Kandagatla
2020-11-04 21:21 ` Rob Herring
2020-10-29 11:08 ` [PATCH v2 5/6] ASoC: codecs: lpass-va-macro: Add support to VA Macro Srinivas Kandagatla
2020-10-29 15:56 ` Pierre-Louis Bossart
2020-11-03 12:31 ` Srinivas Kandagatla
2020-10-29 11:08 ` [PATCH v2 6/6] ASoC: codecs: lpass-va-macro: add dapm widgets and routes Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3300f31e-28d1-becf-41e7-814b38082dcb@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).