From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Curtis Malainey <cujomalainey@google.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
ALSA development <alsa-devel@alsa-project.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Takashi Iwai <tiwai@suse.com>, Hui Wang <hui.wang@canonical.com>,
Ben Zhang <benzh@chromium.org>, Mac Chiang <mac.chiang@intel.com>,
Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Jenny TC <jenny.tc@intel.com>, Bard Liao <bardliao@realtek.com>,
Sathya Prakash M R <sathya.prakash.m.r@intel.com>,
Naveen Manohar <naveen.m@intel.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Jon Flatley <jflat@chromium.org>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>
Subject: Re: [alsa-devel] [RESEND PATCH] ASoC: intel: Add Broadwell rt5650 machine driver
Date: Wed, 4 Dec 2019 21:58:47 -0600 [thread overview]
Message-ID: <359b7c67-dae5-b855-ff0f-226aea1e092b@linux.intel.com> (raw)
In-Reply-To: <CAOReqxjqF6kPyX99i7CzLeTip2yVKezo=Laobuk-SRg6_D2n1Q@mail.gmail.com>
On 12/4/19 4:51 PM, Curtis Malainey wrote:
>>
>>> +/* ASoC machine driver for Broadwell DSP + RT5650 */
>>> +static struct snd_soc_card bdw_rt5650_card = {
>>> + .name = "bdw-rt5650",
>>> + .owner = THIS_MODULE,
>>
>> is this needed?
> Left over from older conventions, any harm in keeping it? All modules
> from that era appear to have it on the card.
>>
>>> + .dai_link = bdw_rt5650_dais,
>>> + .num_links = ARRAY_SIZE(bdw_rt5650_dais),
>>> + .dapm_widgets = bdw_rt5650_widgets,
>>> + .num_dapm_widgets = ARRAY_SIZE(bdw_rt5650_widgets),
>>> + .dapm_routes = bdw_rt5650_map,
>>> + .num_dapm_routes = ARRAY_SIZE(bdw_rt5650_map),
>
>>> +static struct platform_driver bdw_rt5650_audio = {
>>> + .probe = bdw_rt5650_probe,
>>> + .remove = bdw_rt5650_remove,
>>> + .driver = {
>>> + .name = "bdw-rt5650",
>>> + .owner = THIS_MODULE,
>>
>> is this needed?
> Same as above comment
I am pretty sure Coccinelle detects this pattern and would tell you the
core takes care of the .owner for platform drivers. I can't recall for
snd_soc_card.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-12-05 3:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 1:11 [alsa-devel] [RESEND PATCH] ASoC: intel: Add Broadwell rt5650 machine driver Curtis Malainey
2019-12-04 1:23 ` Pierre-Louis Bossart
2019-12-04 21:38 ` Curtis Malainey
2019-12-04 22:51 ` Curtis Malainey
2019-12-05 3:58 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=359b7c67-dae5-b855-ff0f-226aea1e092b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=benzh@chromium.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cujomalainey@chromium.org \
--cc=cujomalainey@google.com \
--cc=hui.wang@canonical.com \
--cc=jenny.tc@intel.com \
--cc=jflat@chromium.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=krzk@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mac.chiang@intel.com \
--cc=naveen.m@intel.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).