alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Vinod Koul <vkoul@kernel.org>
Cc: gregkh@linuxfoundation.org, alsa-devel@alsa-project.org,
	yung-chuan.liao@linux.intel.com, linux-kernel@vger.kernel.org,
	sanyog.r.kale@intel.com
Subject: Re: [PATCH] soundwire: debugfs: use controller id instead of link_id
Date: Thu, 21 Jan 2021 12:22:52 -0600	[thread overview]
Message-ID: <35ae5919-f511-bbe9-7273-2dee11795db4@linux.intel.com> (raw)
In-Reply-To: <feee8676-33fe-7929-8b6c-6abe3a09159a@linaro.org>



> diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c
> index b6cad0d59b7b..f22868614f09 100644
> --- a/drivers/soundwire/debugfs.c
> +++ b/drivers/soundwire/debugfs.c
> @@ -19,13 +19,14 @@ void sdw_bus_debugfs_init(struct sdw_bus *bus)
>                  return;
> 
>          /* create the debugfs master-N */
> +       bus->controller_debugfs = debugfs_create_dir(dev_name(bus->dev), 
> sdw_debugfs_root);

	bus->dev = &md->dev;

dev_name(bus->dev) does not describe a controller at all but an 
individual master.

We might as well just change the information as:

snprintf(name, sizeof(name), "master-%d-%d", bus_id, bus->link_id);

you get the system unique ID and controller-relative ID, and you can 
decide to ignore one or the other on different platform.

  reply	other threads:[~2021-01-21 18:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 16:25 [PATCH] soundwire: debugfs: use controller id instead of link_id Srinivas Kandagatla
2021-01-19 14:52 ` Vinod Koul
2021-01-19 15:54   ` Pierre-Louis Bossart
2021-01-19 17:17     ` Srinivas Kandagatla
2021-01-19 19:09       ` Pierre-Louis Bossart
2021-01-21 12:03         ` Srinivas Kandagatla
2021-01-21 15:12           ` Pierre-Louis Bossart
2021-01-21 17:23             ` Srinivas Kandagatla
2021-01-21 18:22               ` Pierre-Louis Bossart [this message]
2021-02-01 10:14               ` Vinod Koul
2021-02-01 16:10                 ` Pierre-Louis Bossart
2021-02-02  4:18                   ` Vinod Koul
2021-02-02 16:43                     ` Pierre-Louis Bossart
2021-02-03 11:14                       ` Vinod Koul
2021-02-06 10:22                         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35ae5919-f511-bbe9-7273-2dee11795db4@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sanyog.r.kale@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).