From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
vkoul@kernel.org
Cc: sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/6] soundwire: qcom: add support to missing transport params
Date: Mon, 1 Feb 2021 15:50:18 +0000 [thread overview]
Message-ID: <3c801cef-0089-721d-d916-bf3eed060c6c@linaro.org> (raw)
In-Reply-To: <29eb1b75-d92f-9641-8181-1fe250b189ec@linux.intel.com>
On 29/01/2021 19:20, Pierre-Louis Bossart wrote:
>
>> struct qcom_swrm_port_config {
>> u8 si;
>> u8 off1;
>> u8 off2;
>> u8 bp_mode;
>> + u8 hstart;
>> + u8 hstop;
>> + u8 word_length;
>> + u8 bgp_count;
>
> I couldn't figure out what 'bgp' was and had to search. Not sure how you
> came up with this abbreviation of "qcom,ports-block-group-count". Adding
> a comment wouldn't hurt.
I will rename this to blk_group_count which makes more sense!
>
>> + u8 lane_control;
>
> Are you able to use lane_control != 0 ? I thought we were missing stuff
> at the bus.c level?
Am not sure what is missing in bus.c but we do use lane_control for RX
slave on WCD938x codec. This uses datalane 1 for HPH and lane0 for
Compander/Class-H and other ports.
And it works!
--srini
>
next prev parent reply other threads:[~2021-02-01 15:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 17:32 [PATCH 0/6] soundwire: qcom: various improvements Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 1/6] soundwire: qcom: add support to missing transport params Srinivas Kandagatla
2021-01-29 19:20 ` Pierre-Louis Bossart
2021-02-01 15:50 ` Srinivas Kandagatla [this message]
2021-02-01 16:33 ` Pierre-Louis Bossart
2021-02-01 14:13 ` Vinod Koul
2021-02-01 15:50 ` Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 2/6] soundwire: qcom: extract version field Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands Srinivas Kandagatla
2021-01-29 19:21 ` Pierre-Louis Bossart
2021-02-01 14:16 ` Vinod Koul
2021-02-01 15:50 ` Srinivas Kandagatla
2021-02-02 4:46 ` Vinod Koul
2021-01-29 17:32 ` [PATCH 4/6] soundwire: qcom: start the clock during initialization Srinivas Kandagatla
2021-02-01 14:21 ` Vinod Koul
2021-02-01 15:50 ` Srinivas Kandagatla
2021-02-02 4:46 ` Vinod Koul
2021-01-29 17:32 ` [PATCH 5/6] soundwire: qcom: update register read/write routine Srinivas Kandagatla
2021-01-29 19:33 ` Pierre-Louis Bossart
2021-02-01 15:50 ` Srinivas Kandagatla
2021-02-01 16:42 ` Pierre-Louis Bossart
2021-02-02 10:19 ` Srinivas Kandagatla
2021-02-02 16:58 ` Pierre-Louis Bossart
2021-02-01 14:26 ` Vinod Koul
2021-02-01 15:50 ` Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 6/6] soundwire: qcom: add support to new interrupts Srinivas Kandagatla
2021-01-29 19:38 ` Pierre-Louis Bossart
2021-02-01 15:51 ` Srinivas Kandagatla
2021-02-01 14:31 ` Vinod Koul
2021-02-01 15:51 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c801cef-0089-721d-d916-bf3eed060c6c@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).