From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9433C4363D for ; Fri, 2 Oct 2020 08:00:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23166206A5 for ; Fri, 2 Oct 2020 08:00:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="lyU/Ycw9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23166206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 475081ED7; Fri, 2 Oct 2020 09:59:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 475081ED7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601625647; bh=oE1D1DWpe5HU4iEtvRbwIgr+VSMUy2mKeWooGk0Z0IE=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lyU/Ycw9cpwGF1YYEoqpud8kyobt+aIdKVwdA6RRFY6+r7yHetUx4dHu6zO0dL5Ah /I6PSPStQHJsYaLU7sT7Ua97kpibTqQUT/8G1tcFcdzIFe/y2mDHa8IWKSpmjKVLv9 IYwBiTcnfTl48ozzxhqj96MedV0EnlZhrIFdasag= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B1298F801A3; Fri, 2 Oct 2020 09:59:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7C4C0F801ED; Fri, 2 Oct 2020 09:59:54 +0200 (CEST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E7D14F800AB for ; Fri, 2 Oct 2020 09:59:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E7D14F800AB Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOFyg-0006uu-9r; Fri, 02 Oct 2020 09:59:42 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kOFyX-0002aC-Sz; Fri, 02 Oct 2020 09:59:33 +0200 Message-ID: <3e6248770b881181353a00cf2a7087485d1ae0c1.camel@pengutronix.de> Subject: Re: [PATCH 2/5] ASoC: mediatek: mt8192: add platform driver From: Philipp Zabel To: Jiaxin Yu , broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com, robh+dt@kernel.org, tzungbi@google.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Date: Fri, 02 Oct 2020 09:59:33 +0200 In-Reply-To: <1601624142-18991-3-git-send-email-jiaxin.yu@mediatek.com> References: <1601624142-18991-1-git-send-email-jiaxin.yu@mediatek.com> <1601624142-18991-3-git-send-email-jiaxin.yu@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Cc: shane.chien@mediatek.com, maowenan@huawei.com, kuninori.morimoto.gx@renesas.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Jiaxin, On Fri, 2020-10-02 at 15:35 +0800, Jiaxin Yu wrote: > +static int mt8192_afe_pcm_dev_probe(struct platform_device *pdev) > +{ [...] > + /* reset controller to reset audio regs before regmap cache */ > + rstc =3D devm_reset_control_get(dev, "audiosys"); Please use devm_reset_control_get_exclusive() instead. regards Philipp