From: Jaroslav Kysela <perex@perex.cz>
To: David Henningsson <coding@diwic.se>,
alsa-devel@alsa-project.org, tiwai@suse.de
Subject: Re: [PATCH v6] sound: rawmidi: Add framing mode
Date: Mon, 19 Apr 2021 20:00:25 +0200 [thread overview]
Message-ID: <3e6e0cf6-bf65-4e17-5a45-4bc2665abfef@perex.cz> (raw)
In-Reply-To: <20210419164023.159967-1-coding@diwic.se>
Dne 19. 04. 21 v 18:40 David Henningsson napsal(a):
> This commit adds a new framing mode that frames all MIDI data into
> 32-byte frames with a timestamp.
>
> The main benefit is that we can get accurate timestamps even if
> userspace wakeup and processing is not immediate.
>
> Testing on a Celeron N3150 with this mode has a max jitter of 2.8 ms,
> compared to the in-kernel seq implementation which has a max jitter
> of 5 ms during idle and much worse when running scheduler stress tests
> in parallel.
>
> Signed-off-by: David Henningsson <coding@diwic.se>
Nice. Thank you.
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
> @@ -1534,6 +1607,7 @@ static __poll_t snd_rawmidi_poll(struct file *file, poll_table *wait)
> /*
> */
>
> +
> static void snd_rawmidi_proc_info_read(struct snd_info_entry *entry,
> struct snd_info_buffer *buffer)
> {
This is probably a typo chunk?
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2021-04-19 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 16:40 [PATCH v6] sound: rawmidi: Add framing mode David Henningsson
2021-04-19 18:00 ` Jaroslav Kysela [this message]
2021-04-20 9:07 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e6e0cf6-bf65-4e17-5a45-4bc2665abfef@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=coding@diwic.se \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).