From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 0/8] ASoC: add snd_compress_ops and replace
Date: Mon, 20 Apr 2020 14:43:33 -0700 [thread overview]
Message-ID: <3fb997e79dd95ba21070ed37a5b1e3103332309d.camel@linux.intel.com> (raw)
In-Reply-To: <87wo6avdq1.wl-kuninori.morimoto.gx@renesas.com>
On Mon, 2020-04-20 at 16:05 +0900, Kuninori Morimoto wrote:
> Hi Mark
>
> Current snd_soc_component_driver has compr_ops,
> but it is created for ALSA, not for ALSA SoC.
> This means it doesn't know the callback is for which component,
> thus, each callback needs to get component via lookup function.
>
> It is not good design, and will not work in the future,
> because ASoC can have multipul same name component which
> current lookup function can't handle.
>
> This v2 patch-set adds new snd_compress_ops and call
> callbacks with component.
> v1 is here
>
> Link:
> https://lore.kernel.org/alsa-devel/87blnqpuqp.wl-kuninori.morimoto.gx@renesas.com/
>
> Kuninori Morimoto (8):
> ASoC: soc-compress: add snd_compress_ops
> ASoC: codec: wm_adsp: use snd_compress_ops
> ASoC: uniphier: use snd_compress_ops
> ASoC: qcom: q6sp6: use snd_compress_ops
> ASoC: intel: atom: use snd_compress_ops
> ASoC: sof: use snd_compress_ops
> ASoC: sprd: use snd_compress_ops
> ASoC: soc-compress: remove snd_compr_ops
LGTM, Morimoto-san. Thanks!
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
next prev parent reply other threads:[~2020-04-20 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 7:05 [PATCH v2 0/8] ASoC: add snd_compress_ops and replace Kuninori Morimoto
2020-04-20 7:07 ` [PATCH v2 1/8] ASoC: soc-compress: add snd_compress_ops Kuninori Morimoto
2020-04-21 12:49 ` Charles Keepax
2020-04-20 7:08 ` [PATCH v2 2/8] ASoC: codec: wm_adsp: use snd_compress_ops Kuninori Morimoto
2020-04-21 12:51 ` Charles Keepax
2020-04-20 7:08 ` [PATCH v2 3/8] ASoC: uniphier: " Kuninori Morimoto
2020-04-20 7:08 ` [PATCH v2 4/8] ASoC: qcom: q6sp6: " Kuninori Morimoto
2020-04-20 7:09 ` [PATCH v2 5/8] ASoC: intel: atom: " Kuninori Morimoto
2020-04-20 7:09 ` [PATCH v2 6/8] ASoC: sof: " Kuninori Morimoto
2020-04-20 7:10 ` [PATCH v2 7/8] ASoC: sprd: " Kuninori Morimoto
2020-04-20 7:10 ` [PATCH v2 8/8] ASoC: soc-compress: remove snd_compr_ops Kuninori Morimoto
2020-04-21 12:51 ` Charles Keepax
2020-04-20 21:43 ` Ranjani Sridharan [this message]
2020-04-21 18:22 ` [PATCH v2 0/8] ASoC: add snd_compress_ops and replace Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fb997e79dd95ba21070ed37a5b1e3103332309d.camel@linux.intel.com \
--to=ranjani.sridharan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).