From: Sameer Pujar <spujar@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, atalambedu@nvidia.com,
swarren@nvidia.com, lgirdwood@gmail.com, nicoleotsuka@gmail.com,
linux-kernel@vger.kernel.org, nwartikar@nvidia.com,
tiwai@suse.com, robh+dt@kernel.org, viswanathl@nvidia.com,
sharadg@nvidia.com, devicetree@vger.kernel.org,
broonie@kernel.org, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org, jonathanh@nvidia.com,
rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com
Subject: Re: [PATCH v3 06/13] ASoC: simple-card-utils: Expose new members for asoc_simple_priv
Date: Fri, 2 Oct 2020 14:29:06 +0530 [thread overview]
Message-ID: <4069b76e-cc15-2ad9-b241-caabee7e33e3@nvidia.com> (raw)
In-Reply-To: <878scpl7yg.wl-kuninori.morimoto.gx@renesas.com>
>> diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
>> index 86a1e95..9825308 100644
>> --- a/include/sound/simple_card_utils.h
>> +++ b/include/sound/simple_card_utils.h
>> @@ -56,6 +56,10 @@ struct asoc_simple_priv {
>> struct asoc_simple_dai *dais;
>> struct snd_soc_codec_conf *codec_conf;
>> struct gpio_desc *pa_gpio;
>> + const struct snd_soc_ops *ops;
>> + unsigned int force_dpcm:1;
>> + uintptr_t dpcm_selectable;
>> + void *data;
>> };
> I have opinions about these.
>
> About dpcm_selectable, indeed current audio-graph is using it as "uintptr_t",
> but as you know, it checks whether it was non-NULL or not only.
> This means we can use it as bit-field.
Yes that is true. Something like this would work?
graph_probe(...)
{
...
if (of_device_get_match_data(dev))
priv->dpcm_selectable = 1;
...
}
>
> BTW, do we need to have dpcm_selectable at priv ?
Tegra audio graph driver does not require this because already it is
populating 'force_dpcm' flag and having 'selectable' does not make much
sense for it.
>
> One note is that, -scu- user is only me (locally),
> and it will be removed when audio-graph2 was created.
> (My plan is keep code for you, but remove compatible)
Right now I am just keeping it to allow current code work. Later you can
remove this during graph2.
>
> About *data, I think we can avoid *data
> if driver side priv includes asoc_simple_priv ?
>
> struct my_priv {
> struct asoc_simple_priv *simple;
> ...
> };
>
> #define simple_to_priv(_simple) container_of((_simple), struct my_priv, simple)
>
This seems like a better plan, will do this.
next prev parent reply other threads:[~2020-10-02 9:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 17:32 [PATCH v3 00/13] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 01/13] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-10-01 18:53 ` Michał Mirosław
2020-10-02 8:50 ` Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 02/13] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 03/13] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 04/13] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 05/13] ASoC: audio-graph: Support empty Codec endpoint Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 06/13] ASoC: simple-card-utils: Expose new members for asoc_simple_priv Sameer Pujar
2020-10-02 1:45 ` Kuninori Morimoto
2020-10-02 8:59 ` Sameer Pujar [this message]
2020-10-01 17:33 ` [PATCH v3 07/13] ASoC: audio-graph: Update driver as per new exposed members Sameer Pujar
2020-10-02 1:46 ` Kuninori Morimoto
2020-10-02 9:00 ` Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 08/13] ASoC: audio-graph: Expose helpers from audio graph Sameer Pujar
2020-10-02 3:06 ` kernel test robot
2020-10-02 3:07 ` kernel test robot
2020-10-01 17:33 ` [PATCH v3 09/13] ASoC: dt-bindings: tegra: Add schema for audio graph card Sameer Pujar
2020-10-06 20:34 ` Rob Herring
2020-10-07 7:13 ` Sameer Pujar
2020-10-16 5:14 ` Sameer Pujar
2020-10-16 16:42 ` Mark Brown
2020-10-01 17:33 ` [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver Sameer Pujar
2020-10-01 19:07 ` Michał Mirosław
2020-10-01 19:44 ` Jon Hunter
2020-10-01 20:57 ` Dmitry Osipenko
2020-10-01 21:02 ` Dmitry Osipenko
2020-10-02 8:51 ` Sameer Pujar
2020-10-02 5:34 ` Kuninori Morimoto
2020-10-02 9:08 ` Sameer Pujar
2020-10-04 23:20 ` Kuninori Morimoto
2020-10-01 17:33 ` [PATCH v3 11/13] arm64: defconfig: Enable Tegra audio graph " Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 12/13] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 13/13] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4069b76e-cc15-2ad9-b241-caabee7e33e3@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=nicoleotsuka@gmail.com \
--cc=nwartikar@nvidia.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).