From: "Agrawal, Akshu" <aagrawal2@amd.com>
To: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
pierre-louis.bossart@linux.intel.com,
Mark Brown <broonie@kernel.org>,
djkurtz@google.com, Alexander.Deucher@amd.com,
Akshu.Agrawal@amd.com, Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [RESEND PATCH v12 4/6] ASoC: amd: add ACP3x TDM mode support
Date: Tue, 3 Dec 2019 16:01:41 +0530 [thread overview]
Message-ID: <46263e01-fd7f-57c3-64f8-c48e01cdb79c@amd.com> (raw)
In-Reply-To: <1574415866-29715-5-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
On 11/22/2019 3:14 PM, Ravulapati Vishnu vardhan rao wrote:
> ACP3x I2S (CPU DAI) can act in normal I2S and TDM modes. Added support
> for TDM mode. Desired mode can be selected from ASoC machine driver.
>
> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
> ---
> sound/soc/amd/raven/acp3x-i2s.c | 24 ++++++++++++++++++++----
> sound/soc/amd/raven/acp3x.h | 1 +
> 2 files changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
> index 7f05782..cea7311 100644
> --- a/sound/soc/amd/raven/acp3x-i2s.c
> +++ b/sound/soc/amd/raven/acp3x-i2s.c
> @@ -70,11 +70,27 @@ static int acp3x_i2s_set_tdm_slot(struct snd_soc_dai *cpu_dai,
>
> frm_len = FRM_LEN | (slots << 15) | (slot_len << 18);
> if (adata->substream_type == SNDRV_PCM_STREAM_PLAYBACK) {
> - reg_val = mmACP_BTTDM_ITER;
> - frmt_val = mmACP_BTTDM_TXFRMT;
> + switch (adata->i2s_instance) {
> + case I2S_BT_INSTANCE:
> + reg_val = mmACP_BTTDM_ITER;
> + frmt_reg = mmACP_BTTDM_TXFRMT;
Patch 2 of this series declares frmt_val, frmt_reg should cause build
errors.
Thanks,
Akshu
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-03 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1574415866-29715-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
2019-11-22 9:44 ` [alsa-devel] [RESEND PATCH v12 1/6] ASoC: amd:Create multiple I2S platform device endpoint Ravulapati Vishnu vardhan rao
2019-11-22 15:54 ` Pierre-Louis Bossart
2019-11-22 9:44 ` [alsa-devel] [PATCH v12 2/6] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-11-22 15:33 ` Pierre-Louis Bossart
2019-11-22 9:44 ` [alsa-devel] [PATCH v12 3/6] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-12-03 10:59 ` Agrawal, Akshu
2019-11-22 9:44 ` [alsa-devel] [RESEND PATCH v12 4/6] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-12-03 10:31 ` Agrawal, Akshu [this message]
2019-11-22 9:44 ` [alsa-devel] [RESEND PATCH v12 5/6] ASoC: amd: Handle ACP3x I2S-SP Interrupts Ravulapati Vishnu vardhan rao
2019-11-22 9:44 ` [alsa-devel] [RESEND PATCH v12 6/6] ASoC: amd: Added ACP3x system resume and runtime pm Ravulapati Vishnu vardhan rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46263e01-fd7f-57c3-64f8-c48e01cdb79c@amd.com \
--to=aagrawal2@amd.com \
--cc=Akshu.Agrawal@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=djkurtz@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).