Re: [alsa-devel] [PATCH 1/4] ASoC: msm8916-wcd-analog: Fix selected events for MIC BIAS External1

[Srinivas Kandagatla <srinivas.kandagatla@linaro.org>]

On 11/01/2020 16:40, Stephan Gerhold wrote:
> MIC BIAS External1 sets pm8916_wcd_analog_enable_micbias_ext1()
> as event handler, which ends up in pm8916_wcd_analog_enable_micbias_ext().
> 
> But pm8916_wcd_analog_enable_micbias_ext() only handles the POST_PMU
> event, which is not specified in the event flags for MIC BIAS External1.
> This means that the code in the event handler is never actually run.
> 
> Set SND_SOC_DAPM_POST_PMU as the only event for the handler to fix this.
> 
> Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec")
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
Thanks for testing Ext mic bias and the fix.

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

>   sound/soc/codecs/msm8916-wcd-analog.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index f53235be77d9..30b19f12fabc 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -938,10 +938,10 @@ static const struct snd_soc_dapm_widget pm8916_wcd_analog_dapm_widgets[] = {
>   
>   	SND_SOC_DAPM_SUPPLY("MIC BIAS External1", CDC_A_MICB_1_EN, 7, 0,
>   			    pm8916_wcd_analog_enable_micbias_ext1,
> -			    SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
> +			    SND_SOC_DAPM_POST_PMU),
>   	SND_SOC_DAPM_SUPPLY("MIC BIAS External2", CDC_A_MICB_2_EN, 7, 0,
>   			    pm8916_wcd_analog_enable_micbias_ext2,
> -			    SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD),
> +			    SND_SOC_DAPM_POST_PMU),
>   
>   	SND_SOC_DAPM_ADC_E("ADC1", NULL, CDC_A_TX_1_EN, 7, 0,
>   			   pm8916_wcd_analog_enable_adc,
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel