From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E66C2BB1D for ; Fri, 13 Mar 2020 17:31:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BC36206BE for ; Fri, 13 Mar 2020 17:31:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="IkVnzNmn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BC36206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C1F4D1853; Fri, 13 Mar 2020 18:31:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C1F4D1853 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584120711; bh=NnF4hHv/0Zi+R4du+q2CPSdWrrPXCGk5PDq2jxkPUCU=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IkVnzNmnf7QdI4YGkRw55+Nek4undHYqL/jR7agQvyYq2V0YL1wFHM2JDhxwsrKoV PAyjn6qx67FmTzZEmlHDzqUZcYKuS5nhKsDFkY2S+pRG7lEoQrTzCwiQanIGVKEgT0 dg83tbhY69dRBglt3twiABtp45HxxR9QOFj/wyUk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8696BF802A1; Fri, 13 Mar 2020 18:28:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 376BFF802A7; Fri, 13 Mar 2020 18:28:49 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 87DDCF802A1 for ; Fri, 13 Mar 2020 18:28:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 87DDCF802A1 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2020 10:28:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,549,1574150400"; d="scan'208";a="237017183" Received: from sblancoa-mobl.amr.corp.intel.com (HELO [10.251.232.239]) ([10.251.232.239]) by fmsmga008.fm.intel.com with ESMTP; 13 Mar 2020 10:28:28 -0700 Subject: Re: [PATCH 07/16] soundwire: cadence: mask Slave interrupt before stopping clock To: Vinod Koul References: <20200311184128.4212-1-pierre-louis.bossart@linux.intel.com> <20200311184128.4212-8-pierre-louis.bossart@linux.intel.com> <20200313122444.GH4885@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: <4b7d3e8c-b803-c6ae-3072-93f8187604c4@linux.intel.com> Date: Fri, 13 Mar 2020 11:33:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200313122444.GH4885@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , Hui Wang , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> +/** >> + * sdw_cdns_enable_slave_interrupt() - Enable SDW slave interrupts >> + * @cdns: Cadence instance >> + * @state: boolean for true/false >> + */ >> +static void cdns_enable_slave_interrupts(struct sdw_cdns *cdns, bool state) > > Do you want to rename this as cdns_configure_slave_interrupts, with > argument as enable/disable... ? this follows the convention we already have with: int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns, bool state); but it just deals with slave interrupts only.