From: <Codrin.Ciubotariu@microchip.com>
To: <chenzhou10@huawei.com>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [alsa-devel] [PATCH next] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m
Date: Mon, 13 Jan 2020 16:21:39 +0000 [thread overview]
Message-ID: <50064e1e-8295-7ddf-6860-c4b798127dd6@microchip.com> (raw)
In-Reply-To: <20200113133242.144550-1-chenzhou10@huawei.com>
On 13.01.2020 15:32, Chen Zhou wrote:
> If CONFIG_SND_ATMEL_SOC_DMA=m, build error:
>
> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
> (.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'
>
> Function atmel_pcm_dma_platform_register is defined under
> CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in
> CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC.
Arnd sent a more complete patch for this issue:
https://lkml.org/lkml/2019/10/1/620
It wasn't merged due to some integration issues. Could you please try it
and let us know if it fixes your issue?
Thanks and best regards,
Codrin
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> sound/soc/atmel/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index f118c22..d1dc8e6 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA
>
> config SND_ATMEL_SOC_SSC
> tristate
> + select SND_ATMEL_SOC_DMA
> + select SND_ATMEL_SOC_PDC
>
> config SND_ATMEL_SOC_SSC_PDC
> tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
> --
> 2.7.4
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
parent reply other threads:[~2020-01-14 13:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200113133242.144550-1-chenzhou10@huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50064e1e-8295-7ddf-6860-c4b798127dd6@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chenzhou10@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).